Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

chore(ci): be more specific about the underlying ARM OS #1341

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

mdelapenya
Copy link
Contributor

@mdelapenya mdelapenya commented Jul 20, 2021

What does this PR do?

It forces centos-8-arm as the label used by Jenkins to grab the CI workers when the tests need to be run on ARM.

Why is it important?

We are seeing certain flakiness in one single scenario for Debian (See #1271) and we'd like to narrow down the issue: because we have multiple ARM CI workers under the arm label, we want to always use the same.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests (make unit-test), and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

  • The label does exist on Infra's catalog

Related issues

@mdelapenya mdelapenya self-assigned this Jul 20, 2021
@mdelapenya mdelapenya requested a review from a team July 20, 2021 15:37
@mdelapenya mdelapenya marked this pull request as ready for review July 20, 2021 15:39
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to run this a few times a day? In case you'd like to add the cron option in the toplevel options section

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-20T15:37:59.837+0000

  • Duration: 35 min 34 sec

  • Commit: 2e1331f

Test stats 🧪

Test Results
Failed 0
Passed 229
Skipped 0
Total 229

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 229
Skipped 0
Total 229

@adam-stokes adam-stokes merged commit 964b8a1 into elastic:master Jul 20, 2021
mergify bot pushed a commit that referenced this pull request Jul 20, 2021
mergify bot pushed a commit that referenced this pull request Jul 20, 2021
mergify bot pushed a commit that referenced this pull request Jul 20, 2021
mdelapenya added a commit that referenced this pull request Jul 20, 2021
(cherry picked from commit 964b8a1)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit that referenced this pull request Jul 20, 2021
(cherry picked from commit 964b8a1)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit that referenced this pull request Jul 20, 2021
(cherry picked from commit 964b8a1)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
@mdelapenya
Copy link
Contributor Author

Do you want to run this a few times a day? In case you'd like to add the cron option in the toplevel options section

I'd say that with the current frequency it's enough, but I see your point: we could maybe keep a PR open simply running the offending test suite. 🤔 Does it make sense, right?

@mdelapenya mdelapenya deleted the centos-8-arm branch July 21, 2021 05:37
@v1v
Copy link
Member

v1v commented Jul 21, 2021

I thought this PR will remain open, that was the reason for my question, since it's merged then it was not valid :)

@mdelapenya
Copy link
Contributor Author

We can send a new one simplifying the test layout, including the proposed cron

mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Jul 27, 2021
* master:
  chore: read elastic-agent logs using native OS' log manager (elastic#1368)
  Add kubernetes autodiscover scenario without autodiscover (elastic#1361)
  fix: expose fleet-server port (elastic#1348)
  chore: improve the automation for the stack version bump (elastic#1351)
  bump stack version 8.0.0-a6334483 (elastic#1350)
  bump stack version 8.0.0-1e9bea0f (elastic#1346)
  chore(ci): be more specific about the underlying ARM OS (elastic#1341)
  fix: apply container name to elastic-agent Docker services (elastic#1336)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants