chore: move skip responsibility to the automation, not the CI

[mdelapenya]

What does this PR do?

It moves the ability to skip scenarios tagged as @skip from the CI to the automation.

Why is it important?

Now it's possible to decide whether to skip scenarios or not, setting it to true (do skip) by default.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have run the Unit tests for the CLI, and they are passing locally
• I have run the End-2-End tests for the suite I'm working on, and they are passing locally
• I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

• Variable expansion in Makefile

How to test this PR locally

Do not skip scenarios:

$ SUITE="metricbeat" \
    SKIP_SCENARIOS=false \
    TAGS="integrations && apache" DEVELOPER_MODE=true \
    TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE \
    make -C e2e functional-test

go get -v github.com/cucumber/godog/cmd/godog@v0.10.0
go: found github.com/cucumber/godog/cmd/godog in github.com/cucumber/godog v0.10.0
cd _suites/metricbeat && \
	OP_LOG_LEVEL=TRACE \
	OP_LOG_INCLUDE_TIMESTAMP=TRUE \
	TIMEOUT_FACTOR=3 \
	STACK_VERSION= \
	DEVELOPER_MODE=true \
	godog --format=pretty --tags "integrations && apache"

Skip scenarios (default):

$ SUITE="metricbeat" \
    TAGS="integrations && apache" DEVELOPER_MODE=true \
    TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE \
    make -C e2e functional-test

go get -v github.com/cucumber/godog/cmd/godog@v0.10.0
go: found github.com/cucumber/godog/cmd/godog in github.com/cucumber/godog v0.10.0
cd _suites/metricbeat && \
	OP_LOG_LEVEL=TRACE \
	OP_LOG_INCLUDE_TIMESTAMP=TRUE \
	TIMEOUT_FACTOR=3 \
	STACK_VERSION= \
	DEVELOPER_MODE=true \
	godog --format=pretty --tags "integrations && apache && ~skip"

Related issues

• Relates work for issue #379 - adding back rpm and deb tests #439

Follow-ups

[mdelapenya]

The CI logs reflect the changes are positive. Will be able to merge if the CI is green

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Build Cause: mdelapenya commented: jenkins run the tests please

• Start Time: 2020-12-03T11:44:26.265+0000

• Duration: 26 min 41 sec

Test stats 🧪

Test	Results
Failed	0
Passed	78
Skipped	12
Total	90

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test	Results
Failed	0
Passed	78
Skipped	12
Total	90

[mdelapenya]

I ran the CI job setting the new Jenkins input parameter to false, so it won't skip the desired scenarios, causing the two errors (the scenario is skipped).

I'm gonna trigger the CI for the PR again, and if it passes, will merge.

[mdelapenya]

jenkins run the tests please

[mdelapenya]

I quoted the value here, but it ended up adding them to the value instead