This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
chore: append "-amd64" label for Docker images #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
commented
Feb 19, 2021
| @@ -150,11 +151,14 @@ func (i *DockerPackage) Preinstall() error { | |||
| return err | |||
| } | |||
|
|
|||
| // wait for tagging to ensure the loaded image is present | |||
| e2e.Sleep(3 * time.Second) | |||
There was a problem hiding this comment.
I've seen errors on CI with not found images, as load and tag executed in the same second.
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
kuisathaverat
approved these changes
Feb 19, 2021
cachedout
approved these changes
Feb 22, 2021
v1v
approved these changes
Feb 22, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Mar 2, 2021
* chore: append "-amd64" suffix to docker images * chore: append "-amd64" suffix for locally-loaded Docker images * chore: make sure we tag the image after it's loaded * fix: properly load & tag ubi8 images * fix: only add the platform label for local or CI snapshots
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Mar 2, 2021
* chore: append "-amd64" suffix to docker images * chore: append "-amd64" suffix for locally-loaded Docker images * chore: make sure we tag the image after it's loaded * fix: properly load & tag ubi8 images * fix: only add the platform label for local or CI snapshots
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Mar 2, 2021
* chore: append "-amd64" suffix to docker images * chore: append "-amd64" suffix for locally-loaded Docker images * chore: make sure we tag the image after it's loaded * fix: properly load & tag ubi8 images * fix: only add the platform label for local or CI snapshots
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Mar 2, 2021
* chore: append "-amd64" suffix to docker images * chore: append "-amd64" suffix for locally-loaded Docker images * chore: make sure we tag the image after it's loaded * fix: properly load & tag ubi8 images * fix: only add the platform label for local or CI snapshots
mdelapenya
added a commit
that referenced
this pull request
Mar 2, 2021
* chore: append "-amd64" suffix to docker images * chore: append "-amd64" suffix for locally-loaded Docker images * chore: make sure we tag the image after it's loaded * fix: properly load & tag ubi8 images * fix: only add the platform label for local or CI snapshots
mdelapenya
added a commit
that referenced
this pull request
Mar 2, 2021
* chore: append "-amd64" suffix to docker images * chore: append "-amd64" suffix for locally-loaded Docker images * chore: make sure we tag the image after it's loaded * fix: properly load & tag ubi8 images * fix: only add the platform label for local or CI snapshots
mdelapenya
added a commit
that referenced
this pull request
Mar 2, 2021
* chore: append "-amd64" suffix to docker images * chore: append "-amd64" suffix for locally-loaded Docker images * chore: make sure we tag the image after it's loaded * fix: properly load & tag ubi8 images * fix: only add the platform label for local or CI snapshots
mdelapenya
added a commit
that referenced
this pull request
Mar 2, 2021
* chore: append "-amd64" suffix to docker images * chore: append "-amd64" suffix for locally-loaded Docker images * chore: make sure we tag the image after it's loaded * fix: properly load & tag ubi8 images * fix: only add the platform label for local or CI snapshots
8 tasks
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR appends the
-amd64label when requesting Docker images to be pulled by Docker-Compose, but it only adds the suffix for GCP binaries (generated by the Beats CI ) and local images after a local build. At this moment we are hardcoding-amd64, as it's the only supported platform.We discovered a bug in the DockerInstaller builder, as it was not setting the ubi8 image name properly.
Why is it important?
We want to match the new naming schemma in Beats release process.
Checklist
make noticein the proper directory)Author's Checklist
How to test this PR locally
It should consume the stand-alone image, including the new tag.
For a Beats PR: fetching binaries from GCP.
For a Beats Merge: fetching binaries from GCP.
For a Beats Merge: fetching binaries from Official artifacts.
Related issues
Follow-ups
Add support for ARM, depending on the underlying CI worker. How could we implement it?
a. setting an environment variable in the worker with
amd64orarm64, and consuming that variable in the tests.b. detecting the architecture of the worker automatically within the tests, reading $GOOS and $GOARCH