Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta information to fields where this applied #721

Open
2 tasks
webmat opened this issue Jan 13, 2020 · 8 comments
Open
2 tasks

Add meta information to fields where this applied #721

webmat opened this issue Jan 13, 2020 · 8 comments
Labels
ready Issues we'd like to address in the future.

Comments

@webmat
Copy link
Contributor

webmat commented Jan 13, 2020

Elasticsearch recently added the possibility to store meta field information.

We should add support in ECS tooling to start specifying this information, for fields where this applies. The initial proposal is to start defining the following, but more may come:

  • unit: s (seconds)
  • unit: B (bytes)
  • format: pct

Tasks:

  • Add support in the ECS generator
  • Populate meta/unit for all fields where it makes sense

I don't think ECS has a field that tracks percentages at this time. But if it does, we should populate it as well.

@ebeahan
Copy link
Member

ebeahan commented Sep 4, 2020

Related Elasticsearch PR working to document standard metadata entries: elastic/elasticsearch#61941

@ebeahan ebeahan added the ready Issues we'd like to address in the future. label Sep 8, 2020
@ebeahan
Copy link
Member

ebeahan commented Oct 30, 2020

Adding some additional details as metadata entries become more formalized.

Valid values for metric_type:

  • gauge
  • counter

Valid values for unit:

  • percent
  • bytes
  • a time unit
    • d
    • h
    • m
    • s
    • ms
    • micros
    • nanos

@ebeahan
Copy link
Member

ebeahan commented Oct 30, 2020

Related package spec discussion: elastic/package-spec#42

@ebeahan ebeahan added the 1.9.0 label Nov 18, 2020
@webmat
Copy link
Contributor Author

webmat commented Nov 18, 2020

Implementation underway here elastic/integrations#402

@ebeahan
Copy link
Member

ebeahan commented Apr 15, 2021

Need to clarify if it's meta or _meta at the field level. Question posed in another discussion.

@ebeahan
Copy link
Member

ebeahan commented May 3, 2021

Confirmed it's meta at a field level - updating title and description here.

@ebeahan ebeahan changed the title Add _meta information to fields where this applied Add meta information to fields where this applied May 3, 2021
@jsoriano
Copy link
Member

jsoriano commented Nov 9, 2021

This issue has appeared when discussing about the inclusion of dimension fields, here elastic/package-spec#247, but I think that dimensions are a different case. A field can be a dimension in some integration, but not in others, but it should be always used with the same type.

Confirmed it's meta at a field level - updating title and description here.

Regarding this, not sure if this influences the implementation here in ECS, but take into account that the metric type is now a mapping setting, see elastic/elasticsearch#74014

The unit should still be stored in meta.

@ebeahan
Copy link
Member

ebeahan commented Nov 9, 2021

Thanks for the insights, @jsoriano. I've wanted to revisit this topic and align ECS (where it makes sense) with recent developments around metrics/TSDB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Issues we'd like to address in the future.
Projects
None yet
Development

No branches or pull requests

4 participants