-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document standard metadata entries. #61941
Conversation
We standardize on some metadata entries that we plan to later leverage in Kibana in order to provide a better out-of-the-box experience, e.g. different visualizations make sense on gauges and counters.
Pinging @elastic/es-docs (>docs) |
Pinging @elastic/es-search (:Search/Mapping) |
|
||
The type of metric. Recognizes `"gauge"` and `"counter"`. By default, fields | ||
are assumed to not be a metric. This information should only be specified on | ||
numeric fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to explain what gauges and counters are in here. Something like:
The type of metric for time series data. Options are none, "gauge"
and "counter"
.
A gauge is a number representing a point in time that can go up and down.
A counter is a number representing a cumulative amount and is always increasing. Counters can reset to 0 occasionally.
|
||
ratio:: | ||
|
||
Whether the field is a ratio. Recognizes `true` and `false` (default). The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether the field is a ratio. Recognizes `true` and `false` (default). The | |
Whether the field is a ratio or percent. Recognizes `true` and `false` (default). The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding was that we always use ratios in the data we produce, never percentages (ie. ratio * 100), is this assumption wrong? If we have both, do we need to be able to make the distinction via this metadata so that Kibana would know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roncohen @ruflin and I had a small discussion about this yesterday. We see how this can be confusing for users, so we agreed this could be the best approach:
Having only percent
stored as a unit (no need for a ratio flag in meta), where the value is expected to be in the [0-1] notation. This is how Metricbeat stores percentages today.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some editorial suggestions.
Co-authored-by: debadair <debadair@elastic.co>
Thanks @debadair for the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We standardize on some metadata entries that we plan to later leverage in Kibana in order to provide a better out-of-the-box experience, e.g. different visualizations make sense on gauges and counters.
We standardized on some metadata entries that we plan to later leverage
in Kibana in order to provide a better out-of-the-box experience, e.g.
different visualizations make sense on gauges and counters.