-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] wip: data_stream - stage 2 #1145
Conversation
Thanks for opening this @roncohen. Another quick initial change we can do here, is add this PR to the list of "RFC Pull Requests" at the end of the document. |
rfcs/text/0009-data_stream-fields.md
Outdated
@@ -31,6 +31,20 @@ data_stream.namespace | constant_keyword | A user defined namespace. Namespaces | |||
|
|||
In the new indexing strategy, the value of the data stream fields combine to the name of the actual data stream in the following manner `{data_stream.type}-{data_stream.dataset}-{data_stream.namespace}`. This means the fields can only contain characters that are valid as part of names of data streams. | |||
|
|||
The following is the field definitions as a `fields.yml`: | |||
|
|||
```yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's instead add these as a separate YML file at rfcs/text/0009/data_stream.yml
.
It will require a definition for the field set as well.
The definitions for the fields should instead start from what we had in the table above in the RFC. It's fine to be a bit more terse than in the table though, for example we should only cover the currently expected values for namespace.type
, and not mention "we expect values X and Y". The field definitions should also cover the character limitations.
Here's a starting point for the full YML file:
- name: data_stream
title: Data Stream
short: TODO
description: TODO
fields:
- name: type
level: extended
type: keyword
example: logs
description: >
A description
with multiple paragraphs
requires a 'short' description as well.
short: A short version of the description.
- name: dataset
# ...
@exekias Do you know who will take this one over for Ron? |
@webmat 🤚 |
Thanks, @ruflin, for taking over authorship and moving this forward! Here's what I see as outstanding:
|
@ebeahan Updated, let me know if this works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'll adjust the advancement date prior to merging.
@ebeahan Thanks for getting this in. By now there is also a blog post around this that we can reference / link in the future: https://www.elastic.co/blog/an-introduction-to-the-elastic-data-stream-naming-scheme Any next steps needs from my end? |
@ruflin Thanks for sharing the blog post! I think it'd make a great addition to the proposal Let's go ahead and open the next stage's PR, even if the only initial change is updating the stage from 2 to 3. We can use that PR to capture any concerns or feedback that arise. |
Done: #1212 |
Moving this to stage 2
Preview the RFC