Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate definitions of os from host.os and user_agent.os... #168

Merged
merged 3 commits into from
Nov 6, 2018
Merged

Remove duplicate definitions of os from host.os and user_agent.os... #168

merged 3 commits into from
Nov 6, 2018
+5 −160

Commits on Nov 6, 2018

  1. Remove duplicate definitions of os from host.os and `user_agent.o… 

    …s`...

With `os` now a reuseable object, it's now expected in these locations, and the field set should only be declared once.

Having it (and other reuseable objects) appear correctly in `template.json` is still work to be done.
    Mathieu Martin committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    c4749f5 View commit details
    Browse the repository at this point in the history

  2. Remove mentions of this from the changelog. 

    It's not an actual breaking change, it's true.
    Mathieu Martin committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    0a46615 View commit details
    Browse the repository at this point in the history

  3. Add the change to Changelog / 'Improvements'

    Mathieu Martin committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    de3502e View commit details
    Browse the repository at this point in the history