Temporarily remove the user_agent field set...
#172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmat
force-pushed
the
temp-rm-user_agent
branch
from
dbe9801
to
62baee0
Compare
6 tasks
39 tasks
MikePaquette
approved these changes
Nov 6, 2018
webmat
force-pushed
the
temp-rm-user_agent
branch
from
62baee0
to
6cd4250
Compare
added 4 commits
November 7, 2018 11:45
We feel that the `user_agent` field set is too implementation-specific. We are therefore taking it out of the Beta1 release. We will review other user agent parsers and update the field set to be more excellent ;-) We will add it again afterwards.
webmat
force-pushed
the
temp-rm-user_agent
branch
from
6cd4250
to
7dc3871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We feel that the
user_agentfield set is too implementation-specific.We are therefore taking it out of the Beta1 release. We will review other
user agent parsers and update the field set to be more excellent ;-)
We will add it again afterwards.
Note that this PR is building on top of #171 and should not be merged before.