Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify static output format for event.duration #425

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Specify static output format for event.duration #425

merged 1 commit into from
Apr 15, 2019

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Apr 10, 2019

We fixed it Beats in elastic/beats#11675. This brings
back the change in ECS, so the next version of ECS doesn't overwrite the fix.

Static ms output format isn't great, it's just the least bad option :-\

@webmat webmat self-assigned this Apr 10, 2019
@webmat webmat requested a review from ruflin April 10, 2019 18:51
ruflin
ruflin approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. As mentioned in the Beats PR, I would hope we have better options in KB in the future.

@webmat webmat merged commit 718e73b into elastic:master Apr 15, 2019
@webmat webmat deleted the fix-event-duration branch April 15, 2019 13:43
webmat added a commit to webmat/ecs that referenced this pull request Apr 15, 2019
@webmat
Specify static output format for event.duration (elastic#425)
2b4b36f 
Static ms output format isn't great, it's just the least bad option
@webmat webmat mentioned this pull request Apr 15, 2019
Merged
webmat added a commit that referenced this pull request Apr 16, 2019
@webmat
Backport #425 to 1.0: Specify static output format for event.duration (…
c96cb10 
…#432)

Backport of PR #425 to 1.0 branch. Original message:

Static ms output format isn't great, it's just the least bad option
@webmat webmat mentioned this pull request May 22, 2019
Merged
webmat pushed a commit to webmat/ecs that referenced this pull request May 24, 2019
Add secondary PR to a changelog entry.
4c464c4 
Initial PR elastic#385 was tweaked by elastic#425. But only elastic#425 was backported to 1.0.
webmat pushed a commit to webmat/ecs that referenced this pull request May 24, 2019
Adjust changelog entry for this backport.
8e2b9da 
event.duration had already been backported to 1.0 via elastic#425.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@webmat webmat

Labels
v1.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmat @ruflin