Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go get golang.org/x/lint/golint is failing in CI #104

Closed
dliappis opened this issue Mar 18, 2024 · 2 comments · Fixed by #105
Closed

go get golang.org/x/lint/golint is failing in CI #104

dliappis opened this issue Mar 18, 2024 · 2 comments · Fixed by #105
Labels
ci

Comments

@dliappis
Copy link
Contributor

When raising a new PR, e.g. #103

we see the following failure (bk link):

# golang.org/x/tools/go/types/objectpath
/go/src/golang.org/x/tools/go/types/objectpath/objectpath.go:397:10: meth.Origin undefined (type *types.Func has no field or method Origin)
Error: running "go get golang.org/x/lint/golint" failed with exit code 2
🚨 Error: The command exited with status 2
user command error: exit status 2
@dliappis dliappis added the ci label Mar 18, 2024
@cmacknz
Copy link
Member

cmacknz commented Mar 18, 2024

This repository doesn't have a .go-version file so possibly the Go version is too old.

dliappis added a commit to dliappis/elastic-agent-client that referenced this issue Mar 18, 2024
@dliappis
Bump Golang for CI
e1ea055 
This commit bumps the Golang version (used by the container image for
CI steps) to fix the failing lint test.

Closes elastic#104
@dliappis dliappis mentioned this issue Mar 18, 2024
Merged
@dliappis
Copy link
Contributor Author

This repository doesn't have a .go-version file so possibly the Go version is too old.

Thanks! I took a quick look both steps, including the failing lint steps seem to run using the docker image golang:${SETUP_GOLANG_VERSION} where SETUP_GOLANG_VERSION: '1.18.10'.

I tried the reproduction locally and using a newer docker image seems to work fine.

To get CI working I raised #105

cmacknz pushed a commit that referenced this issue Mar 18, 2024
@dliappis
Bump Golang for CI (#105)
ad52e81 
This commit bumps the Golang version (used by the container image for
CI steps) to fix the failing lint test.

Closes #104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump Golang for CI dliappis/elastic-agent-client
2 participants
@dliappis @cmacknz