-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing/certutil: add support to RSA #231
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndersonQ
added
the
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
label
Sep 27, 2024
AndersonQ
requested review from
rdner and
VihasMakwana
and removed request for
a team
September 27, 2024 15:20
8 tasks
AndersonQ
requested review from
belimawr
and removed request for
VihasMakwana
September 27, 2024 15:25
ycombinator
added
Team:Elastic-Agent-Data-Plane
Label for the Agent Data Plane team
and removed
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
labels
Sep 27, 2024
AndersonQ
force-pushed
the
certutil-rsa
branch
from
September 30, 2024 12:49
95c13e9
to
fcae5b8
Compare
/test |
AndersonQ
force-pushed
the
certutil-rsa
branch
2 times, most recently
from
September 30, 2024 17:28
5e9fd64
to
162e7fc
Compare
* add support to generate RSA certificates * add `-rsa` cli to generate RSA certificates * fix CI: use go.elastic.co/go-licence-detector defined on go.mod
AndersonQ
force-pushed
the
certutil-rsa
branch
from
October 1, 2024 10:32
162e7fc
to
27d7dcb
Compare
mauri870
reviewed
Oct 1, 2024
mauri870
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, confirmed that it can generate valid rsa keys.
good catch, it was a leftover from while I was refactoring. Also |
/test |
💚 Build Succeeded
History
cc @AndersonQ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enhance
testing/certutil
:-rsa
cli to generate RSA certificatesWhy is it important?
RSA keys are needed to test:
Checklist
How to test
the following should generate RSA keys:
verify the certificates with:
the keys with:
Related issues