Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kibana: add CreateFleetServerHosts and CreateFleetProxy #246

Merged
merged 6 commits into from
Nov 1, 2024
Merged

kibana: add CreateFleetServerHosts and CreateFleetProxy #246

merged 6 commits into from
Nov 1, 2024

Conversation

AndersonQ
Copy link
Member

@AndersonQ AndersonQ commented Oct 30, 2024 •
edited
Loading

What does this PR do?

Adds kibana.CreateFleetProxy and kibana.CreateFleetServerHosts

Why is it important?

Those kibana APIs are needed for the tests added on elastic/elastic-agent#5889

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@AndersonQ AndersonQ self-assigned this Oct 30, 2024
@AndersonQ AndersonQ requested a review from a team as a code owner October 30, 2024 09:43
@AndersonQ AndersonQ requested review from faec and VihasMakwana and removed request for a team October 30, 2024 09:43
@AndersonQ AndersonQ marked this pull request as draft October 30, 2024 09:43
@AndersonQ AndersonQ force-pushed the 5716-5491-mtls-integration-test branch from cdd8d85 to 2c550e8 Compare October 30, 2024 14:24
@AndersonQ AndersonQ mentioned this pull request Oct 31, 2024
Merged
4 tasks
@AndersonQ AndersonQ changed the title [WIP] 5716 5491 mtls integration test kibana: add NewFleetServerHosts and CreateFleetProxy Oct 31, 2024
@AndersonQ AndersonQ changed the title kibana: add NewFleetServerHosts and CreateFleetProxy kibana: add CreateFleetServerHosts and CreateFleetProxy Oct 31, 2024
@AndersonQ AndersonQ force-pushed the 5716-5491-mtls-integration-test branch from 2c550e8 to 6146d7f Compare October 31, 2024 14:20
@AndersonQ AndersonQ marked this pull request as ready for review October 31, 2024 14:22
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 31, 2024
@pierrehilbert pierrehilbert requested review from rdner and removed request for VihasMakwana October 31, 2024 16:38
rdner
rdner reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we never check HTTP status codes, is there any reason not to do that?

kibana/fleet.go Outdated Show resolved Hide resolved
kibana/fleet.go Outdated Show resolved Hide resolved
kibana/fleet.go Show resolved Hide resolved
kibana/fleet.go Show resolved Hide resolved
kibana/fleet.go Outdated Show resolved Hide resolved
kibana/fleet.go Outdated Show resolved Hide resolved
@AndersonQ AndersonQ requested a review from rdner November 1, 2024 10:03
rdner
rdner approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@rdner rdner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but we should decide on HTTP status code checks. I'm fine with a follow up PR for this too.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @AndersonQ

@AndersonQ AndersonQ merged commit 038fdc1 into elastic:main Nov 1, 2024
6 checks passed
@AndersonQ AndersonQ deleted the 5716-5491-mtls-integration-test branch November 1, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdner rdner rdner approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@AndersonQ AndersonQ

Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndersonQ @elasticmachine @rdner @pierrehilbert