Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cgroups log line from Infof from Debugf #175

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Aug 12, 2024

What does this PR do?

This is a one-liner that removes an erroneous Infof() debug line that should have been a Debugf() line.

Why is it important?

This can create lots of logging noise.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

@fearful-symmetry fearful-symmetry added the bug Something isn't working label Aug 12, 2024
@fearful-symmetry fearful-symmetry self-assigned this Aug 12, 2024
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner August 12, 2024 19:48
@fearful-symmetry fearful-symmetry requested review from mauri870 and leehinman and removed request for a team August 12, 2024 19:48
@cmacknz
Copy link
Member

cmacknz commented Aug 12, 2024

Did a quick spot check and this looks like the only thing that should have been debug level:

❯ rg '\.Info' metric/system
metric/system/host/host.go
80:             info := h.Info()

metric/system/diskio/diskstat_windows_helper.go
144:            logp.L().Named("diskio").Info("The registry key EnableCounterForIoctl at HKLM:SYSTEM\\CurrentControlSet\\Services\\Partmgr has been created in order to enable the performance counters")

metric/system/cgroup/util.go
480:                            logp.L().Infof("using root mount %s and path %s", r.cgroupMountpoints.ContainerizedRootMount, path)

metric/system/cgroup/cgv2/io_helper_linux.go
46:             fInfo, dirErr := d.Info()

@fearful-symmetry fearful-symmetry merged commit e622b66 into elastic:main Aug 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants