Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inspect command does not honour inputs.d external input directory #622

Open
ChrsMark opened this issue Jun 27, 2022 · 0 comments
Open

inspect command does not honour inputs.d external input directory #622

ChrsMark opened this issue Jun 27, 2022 · 0 comments
Labels
enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@ChrsMark
Copy link
Member

ChrsMark commented Jun 27, 2022 •
edited
Loading

At 3c2072d support for inputs.d external input directory was added. However elastic-agent inspect command seems to not take into account the inputs.d directory during its execution.

I was checking the code of the command at

elastic-agent/internal/pkg/agent/cmd/inspect.go

Line 286 in a950518

and it might misses to include the additional configs like it happens at

elastic-agent/internal/pkg/agent/application/local_mode.go

Line 121 in 07a476d

discover := discoverer(pathConfigFile, cfg.Settings.Path, externalConfigsGlob())

Since inspect command is really useful for evaluating policies etc it would be nice to provide full access to any additional inputs available.

cc: @kvch
@ChrsMark ChrsMark added the enhancement New feature or request label Jun 27, 2022
@jlind23 jlind23 added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Jun 27, 2022
@ChrsMark ChrsMark mentioned this issue Jul 4, 2022
Closed
@ChrsMark ChrsMark mentioned this issue Jul 29, 2022
Merged
ruflin added a commit to ruflin/elastic-agent that referenced this issue Apr 28, 2023
@ruflin
Add documentation around inputs.d to config file
e165260 
The inputs.d feature was added in elastic/beats#30087 for elastic agent but unfortunately without any documentation. inputs.d directory is especially useful in the elastic-agent standalone mode. The close the first gap around documentation, I added it to the elastic-agent.yml file.

For awareness, this is an open issue around inputs.d directory: elastic#622
@ruflin ruflin mentioned this issue Apr 28, 2023
Merged
ruflin added a commit that referenced this issue May 3, 2023
@ruflin
Add documentation around inputs.d to config file (#2574)
e3f12fd 
The inputs.d feature was added in elastic/beats#30087 for elastic agent but unfortunately without any documentation. inputs.d directory is especially useful in the elastic-agent standalone mode. The close the first gap around documentation, I added it to the elastic-agent.yml file.

For awareness, this is an open issue around inputs.d directory: #622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrsMark @jlind23