-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport: Add 8.4 branch #1223
backport: Add 8.4 branch #1223
Conversation
This pull request does not have a backport label. Could you fix it @v1v? 🙏
NOTE: |
This PR was created by running: RELEASE_TYPE=patch \
CURRENT_RELEASE=8.4.2 \
PROJECT_OWNER=elastic \
PROJECT=elastic-agent \
make -C release_scripts prepare-next-release create-prs-next-release @amannocci , I'm not sure if this PR is correct for Would you mind double checking if this is the expected behaviour? Otherwise, would you mind revisiting the scripts to reflect the required changes? 🙏 |
- name: backport patches to 8.4 branch | ||
conditions: | ||
- merged | ||
- label=backport-v8.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unexpected value!?
🌐 Coverage report
|
@@ -207,6 +207,19 @@ pull_request_rules: | |||
labels: | |||
- "backport" | |||
title: "[{{ destination_branch }}](backport #{{ number }}) {{ title }}" | |||
- name: backport patches to 8.4 branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same block already exists below at line 223, likely because this shouldn't run for patch releases, only major/minor releases that create a new branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yah, assuming this can be closed. Tell me and I'll re-open it if I'm wrong, hah.
I will check the behavior of the automation. AFAIK, we have two things wrong here. The PR should be raised only for minor/major releases and the merge within the mergify file isn't correct. |
Merge as soon as 8.4 branch was created. Auto-merge is not yet supported, see Mergifyio/mergify#2821