-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix components permissions on build #1716
Conversation
This pull request does not have a backport label. Could you fix it @michalpristas? 🙏
NOTE: |
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
|
🌐 Coverage report
|
Jenkins test this please |
Jenkins test this please |
test failures not related |
dependencies := []string{ | ||
"auditbeat", "filebeat", "heartbeat", "metricbeat", "osquerybeat", "packetbeat", // beat dependencies | ||
"apm-server", | ||
// "cloudbeat", // TODO: add once working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloudbeat v2 alignment was done here.
Anything else we need to do to remove this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is anything blocking inclusion of Cloudbeat here, easiest fix is for you to submit a PR :)
## What does this PR do? Adding cloudbeat to external flow, only supports `linux/amd64` and `linux/arm64` Following [this comment](#1716 (comment)) by @cmacknz ## Why is it important? Will improve dev flow for cloudbeat team ## Checklist - [x] My code follows the style guidelines of this project - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have made corresponding change to the default configuration files - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added an entry in `CHANGELOG.next.asciidoc` or `CHANGELOG-developer.next.asciidoc`. ## Author's Checklist - [ ] tested with #1908 ## Related issues - Requires #1908 --------- Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
What does this PR do?
Endpoint and fleet server permissions were incorrectly set.
This PR fixes that to be 755 instead of 660
This PR also makes EXTERNAL true by default so each dependency is fetched on build for packaging when using
mage dev:package
EXTERNAL is not set when EXTERNAL was already provided or DROP PATH is used.
When using EXTERNAL all dependencies (incl fleet-server, apm, endpoint) are fetched compared to the list of beats from beats repo when used without this flag. This is to be as close to CI package as possible.
Why is it important?
Fixes: #1712
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.