Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.6](backport #1908) Filter binaries by platform when EXTERNAL=true #1977

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 21, 2022

This is an automatic backport of pull request #1908 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Filter binaries by platform when EXTERNAL=true

Not all binaries are available for every platform, and if we try to
download a binary from an artifact URL that doesn't exist the build
fails.

* Update e2e-testing/downloads, handle download errs.

Rather than panicing when we attempt to download an artifact on an
unsupported platform, we ignore the error and log that we are skipping
the download.

* Remove beats dependency.

* Remove redundant word from log

Co-authored-by: Anderson Queiroz <me@andersonq.me>

Co-authored-by: Anderson Queiroz <me@andersonq.me>
(cherry picked from commit a0e6108)
@mergify mergify bot requested a review from a team as a code owner December 21, 2022 15:13
@mergify mergify bot added the backport label Dec 21, 2022
@mergify mergify bot requested review from michalpristas and blakerouse and removed request for a team December 21, 2022 15:13
@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-21T15:13:28.086+0000

  • Duration: 19 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 4741
Skipped 13
Total 4754

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.333% (59/60) 👍
Files 69.565% (144/207) 👍
Classes 69.388% (272/392) 👍
Methods 54.188% (828/1528) 👎 -0.035
Lines 39.372% (8982/22813) 👎 -0.015
Conditionals 100.0% (0/0) 💚

@mergify
Copy link
Contributor Author

mergify bot commented Dec 22, 2022

This pull request has not been merged yet. Could you please review and merge it @cmacknz? 🙏

@cmacknz cmacknz merged commit 4ac9ad4 into 8.6 Dec 22, 2022
@cmacknz cmacknz deleted the mergify/bp/8.6/pr-1908 branch December 22, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants