Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use replicaset and Job MetaGen based on watchers #2711

Merged
merged 9 commits into from
May 31, 2023

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented May 18, 2023

Respective PR for elastic/elastic-agent-autodiscover#44 part of elastic/elastic-agent-autodiscover#31.

Blocked until elastic/elastic-agent-autodiscover#44 is merged and a new version of the autodiscovery library is released.

How to test this PR locally

  1. Build Agent using DEV=true PLATFORMS=linux/amd64 PACKAGES=docker mage -v package
  2. Build a custom docker image out of the previous build using the file from build/package/elastic-agent/elastic-agent-linux-amd64.docker/docker-build directory.
  3. Load the image into a kind cluster using kind load docker-image custom-agent
  4. Deploy Agent standalone on k8s using the custom image
  5. Verify that k8s autodiscovery work as expected (with the container logs part for example) and that job/cronjob , deployment/replicaset metadata are being populated properly.

Screenshots

rsAgent
cronsAgent

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark self-assigned this May 18, 2023
@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

This pull request does not have a backport label. Could you fix it @ChrsMark? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elasticmachine
Copy link
Contributor

elasticmachine commented May 18, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-31T09:04:25.933+0000

  • Duration: 19 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 5663
Skipped 19
Total 5682

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark marked this pull request as ready for review May 26, 2023 12:39
@ChrsMark ChrsMark requested a review from a team as a code owner May 26, 2023 12:39
@ChrsMark ChrsMark requested review from blakerouse, michel-laterman, a team, MichaelKatsoulis, constanca-m and gizas and removed request for a team, blakerouse and michel-laterman May 26, 2023 12:39
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@mergify
Copy link
Contributor

mergify bot commented May 26, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b rs_cj_watchers upstream/rs_cj_watchers
git merge upstream/main
git push upstream rs_cj_watchers

gizas
gizas previously approved these changes May 29, 2023
Co-authored-by: Michael Katsoulis <michaelkatsoulis88@gmail.com>
@mergify
Copy link
Contributor

mergify bot commented May 29, 2023

This pull request does not have a backport label. Could you fix it @ChrsMark? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
gizas
gizas previously approved these changes May 31, 2023
@gizas gizas dismissed stale reviews from MichaelKatsoulis and themself via 00a0c67 May 31, 2023 09:04
@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.611% (71/72) 👍
Files 68.273% (170/249) 👍
Classes 67.021% (315/470) 👍
Methods 53.678% (956/1781) 👍
Lines 39.493% (11020/27904) 👎 -0.049
Conditionals 100.0% (0/0) 💚

@ChrsMark ChrsMark enabled auto-merge (squash) May 31, 2023 09:27
@ChrsMark ChrsMark requested a review from rdner May 31, 2023 09:38
@ChrsMark ChrsMark merged commit 5f61291 into elastic:main May 31, 2023
@faec faec added the backport-v8.8.0 Automated backport with mergify label Jun 2, 2023
mergify bot pushed a commit that referenced this pull request Jun 2, 2023
faec added a commit that referenced this pull request Jun 2, 2023
#2773)

* Use replicaset and Job MetaGen based on watchers (#2711)

(cherry picked from commit 5f61291)

* make check-ci

---------

Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
faec added a commit to faec/elastic-agent that referenced this pull request Jun 2, 2023
@faec faec mentioned this pull request Jun 2, 2023
faec added a commit to faec/elastic-agent that referenced this pull request Jun 2, 2023
@faec faec mentioned this pull request Jun 2, 2023
faec added a commit that referenced this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants