Fix a bunch of errorlint errors from our linters

[ph]

This fixes a lot of the error detecting by our linters, this skip the
errors related to the errors packages, we should refactor the usage or
our package instead.

What does this PR do?

Why is it important?

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

• [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

[ph]

/test

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2022-04-26T12:29:30.288+0000

• Duration: 34 min 3 sec

Test stats 🧪

Test	Results
Failed	0
Passed	3849
Skipped	21
Total	3870

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages.

• run integration tests : Run the Elastic Agent Integration tests.

• run end-to-end tests : Generate the packages and run the E2E Tests.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[ph]

This shouldn't be here, this actually makes the linter run twice and it should only be run by the github action.

[ph]

/test

[AndersonQ]

I think you might have misses a ! on a if statement. I commented there

[AndersonQ]

you still have failing tests, but so far so good :)

[ph]

@AndersonQ well the linter... is a work in progress. I think the next one is the errcheck.
@mdelapenya or @ChrsMark I see an e2e test failing on k8s, Is this a known issue or I should investigate it?

[2022-04-26T14:24:10.545Z]     Then "elastic-agent" collects events with "kubernetes.pod.name:redis" # autodiscover_test.go:295 -> *podsManager

[2022-04-26T14:24:10.545Z]     context deadline exceeded

[2022-04-26T14:24:10.545Z] TRAC[2022-04-26T14:24:09Z] Executing command                             args="[export logs --name kind-a2627034-35d0-4f57-9620-83f7ceb14414 /home/admin/e2e-testing/outputs/kubernetes-autodiscover/kind-a2627034-35d0-4f57-9620-83f7ceb14414]" command=kind env="map[]"

[2022-04-26T14:24:10.546Z] TRAC[2022-04-26T14:24:09Z] Output                                        output=/home/admin/e2e-testing/outputs/kubernetes-autodiscover/kind-a2627034-35d0-4f57-9620-83f7ceb14414

[2022-04-26T14:24:10.546Z] INFO[2022-04-26T14:24:09Z] Kind cluster logs exported                    cluster=kind-a2627034-35d0-4f57-9620-83f7ceb14414 path=/home/admin/e2e-testing/outputs/kubernetes-autodiscover/kind-a2627034-35d0-4f57-9620-83f7ceb14414

[2022-04-26T14:24:10.546Z] TRAC[2022-04-26T14:24:09Z] Executing command                             args="[delete cluster --name kind-a2627034-35d0-4f57-9620-83f7ceb14414]" command=kind env="map[]"

[2022-04-26T14:24:11.932Z] TRAC[2022-04-26T14:24:11Z] Output                                        output=

[2022-04-26T14:24:11.932Z] INFO[2022-04-26T14:24:11Z] kind cluster  was deleted                    

[2022-04-26T14:25:19.687Z] 

[2022-04-26T14:25:19.687Z] --- Failed steps:

[2022-04-26T14:25:19.687Z] 

[2022-04-26T14:25:19.687Z]   Scenario: Logs collection from running pod # features/elastic_agent_standalone.feature:9

[2022-04-26T14:25:19.687Z]     Then "elastic-agent" collects events with "kubernetes.pod.name:a-pod" # features/elastic_agent_standalone.feature:12

[2022-04-26T14:25:19.687Z]       Error: context deadline exceeded

[2022-04-26T14:25:19.687Z] 

[2022-04-26T14:25:19.687Z]   Scenario: Logs collection from a pod with an init container # features/elastic_agent_standalone.feature:14

[2022-04-26T14:25:19.687Z]     Then "elastic-agent" collects events with "kubernetes.container.name:init-container" # features/elastic_agent_standalone.feature:17

[2022-04-26T14:25:19.687Z]       Error: context deadline exceeded

[2022-04-26T14:25:19.687Z] 

[2022-04-26T14:25:19.687Z]   Scenario: Logs collection from short-living cronjobs # features/elastic_agent_standalone.feature:22

[2022-04-26T14:25:19.687Z]     Then "elastic-agent" collects events with "kubernetes.container.name:cronjob-container" # features/elastic_agent_standalone.feature:26

[2022-04-26T14:25:19.687Z]       Error: context deadline exceeded

[2022-04-26T14:25:19.687Z] 

[2022-04-26T14:25:19.687Z]   Scenario: Logs collection from failing pod # features/elastic_agent_standalone.feature:28

[2022-04-26T14:25:19.687Z]     Then "elastic-agent" collects events with "kubernetes.pod.name:a-failing-pod" # features/elastic_agent_standalone.feature:31

[2022-04-26T14:25:19.687Z]       Error: context deadline exceeded

[2022-04-26T14:25:19.687Z] 

[2022-04-26T14:25:19.687Z]   Scenario: Metrics collection configured from targeted Redis Pod # features/elastic_agent_standalone.feature:33

[2022-04-26T14:25:19.687Z]     Then "elastic-agent" collects events with "kubernetes.pod.name:redis" # features/elastic_agent_standalone.feature:36

[2022-04-26T14:25:19.687Z]       Error: context deadline exceeded

[2022-04-26T14:25:19.687Z] 

[mdelapenya]

@AndersonQ well the linter... is a work in progress. I think the next one is the errcheck. @mdelapenya or @ChrsMark I see an e2e test failing on k8s, Is this a known issue or I should investigate it?

The team is working on it elastic/e2e-testing#2434, thanks for the ping!