Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ownership of component specs in elastic-agent docker image #5616

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

pchila
Copy link
Member

@pchila pchila commented Sep 25, 2024

What does this PR do?

Fix ownership of components' spec files in <agent install dir>/data/elastic-agent-<commit>/components/*.yml from root:root to <user>:<user> where user is the default user the agent process will be started with

Why is it important?

To prevent permissions mismatches between component binaries and their spec yaml files under ../components

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pchila pchila added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog labels Sep 25, 2024
@pchila pchila self-assigned this Sep 25, 2024
@pchila pchila requested a review from a team as a code owner September 25, 2024 14:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

mergify bot commented Sep 25, 2024

This pull request does not have a backport label. Could you fix it @pchila? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Sep 25, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 25, 2024
@jlind23
Copy link
Contributor

jlind23 commented Sep 25, 2024

CI will be failing until this is reverted - elastic/beats#40980
cc @ycombinator

@pchila
Copy link
Member Author

pchila commented Sep 26, 2024

/test

@pchila
Copy link
Member Author

pchila commented Sep 26, 2024

@jlind23 @ycombinator elastic/beats#40980 has been merged (I assume that this was the revert @jlind23 referred to) but there are still a lot of leak/integration/serverless test failures...

While having TestAPMConfig fail can be expected (especially since apm server is not healthy) shouldn't the other failures disappear after merging elastic/beats#40980 ?

@jlind23
Copy link
Contributor

jlind23 commented Sep 26, 2024

@pchila You should be able to rebuild it and it will go away. The problem was fixed only a few minutes ago once the new unified release was available.

@pchila
Copy link
Member Author

pchila commented Sep 27, 2024

/test

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@ycombinator
Copy link
Contributor

We need this change for Integrations Server on ESS to spin up without errors and the CI failures are unrelated to this PR. So force merging...

@ycombinator ycombinator merged commit 1a10c3d into elastic:main Sep 27, 2024
10 of 14 checks passed
mergify bot pushed a commit that referenced this pull request Sep 27, 2024
Co-authored-by: Julien Lind <julien.lind@elastic.co>
(cherry picked from commit 1a10c3d)
ycombinator pushed a commit that referenced this pull request Sep 27, 2024
#5620)

Co-authored-by: Julien Lind <julien.lind@elastic.co>
(cherry picked from commit 1a10c3d)

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify bug Something isn't working skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet]: Hosted fleet server gets unhealthy on 8.16 Snapshot.
6 participants