fix(flamegraph): solve animation regression occurring with 6db2677 (#…

…1541) Mandatory nature of the internal `animation` property is restored, and the `animation: {duration}` in the chart specification API reaches the render code again fix #1540
elastic · Dec 30, 2021 · 5ec6037 · 5ec6037
1 parent 59002df
commit 5ec6037
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 1 deletion.
diff --git a/packages/charts/src/chart_types/partition_chart/layout/types/config_types.ts b/packages/charts/src/chart_types/partition_chart/layout/types/config_types.ts
@@ -36,7 +36,7 @@ export interface AnimKeyframe {
 /** @public */
 export interface AnimationConfig {
   /** @alpha */
-  animation?: {
+  animation: {
     duration: TimeMs;
     keyframes?: Array<AnimKeyframe>;
   };

diff --git a/packages/charts/src/chart_types/partition_chart/layout/types/viewmodel_types.ts b/packages/charts/src/chart_types/partition_chart/layout/types/viewmodel_types.ts
@@ -208,6 +208,7 @@ export const nullShapeViewModel = (
     width: 0,
     height: 0,
   },
+  animation: { duration: 0 },
 });
 
 /** @internal */

diff --git a/packages/charts/src/chart_types/partition_chart/layout/viewmodel/viewmodel.ts b/packages/charts/src/chart_types/partition_chart/layout/viewmodel/viewmodel.ts
@@ -309,6 +309,7 @@ export function shapeViewModel(
     clockwiseSectors,
     maxRowCount,
     specialFirstInnermostSector,
+    animation,
   } = spec;
   const {
     emptySizeRatio,
@@ -511,6 +512,7 @@ export function shapeViewModel(
     pickQuads,
     outerRadius,
     chartDimensions,
+    animation,
   };
 }
 

diff --git a/packages/charts/src/chart_types/partition_chart/specs/index.ts b/packages/charts/src/chart_types/partition_chart/specs/index.ts
@@ -68,6 +68,7 @@ const defaultProps = {
   radiusOutside: 128,
   fillRectangleWidth: Infinity,
   fillRectangleHeight: Infinity,
+  animation: { duration: 0 },
 };
 
 /**
@@ -128,5 +129,6 @@ export const Partition: React.FunctionComponent<SpecRequiredProps & SpecOptional
     | 'radiusOutside'
     | 'fillRectangleWidth'
     | 'fillRectangleHeight'
+    | 'animation'
   >(defaultProps),
 );
diff --git a/packages/charts/src/mocks/specs/specs.ts b/packages/charts/src/mocks/specs/specs.ts
@@ -147,6 +147,7 @@ export class MockSeriesSpec {
         fillLabel: {},
       },
     ],
+    animation: { duration: 0 },
     data: [],
   };
 
@@ -177,6 +178,7 @@ export class MockSeriesSpec {
         fillLabel: {},
       },
     ],
+    animation: { duration: 0 },
     data: [],
   };