fix: add code review feedback

elastic · Apr 12, 2021 · 9b11e85 · 9b11e85
1 parent 5935818
commit 9b11e85
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/chart_types/xy_chart/renderer/canvas/xy_chart.tsx b/src/chart_types/xy_chart/renderer/canvas/xy_chart.tsx
@@ -161,8 +161,7 @@ class XYChartComponent extends React.Component<XYChartProps> {
       this.ctx = null;
       return null;
     }
-    const multipleSeriesTypes: string[] = [];
-    seriesTypes.forEach((value) => multipleSeriesTypes.push(value));
+
     const chartSeriesTypes =
       seriesTypes.size > 1 ? `Mixed chart: ${[...seriesTypes].join(' and ')} chart` : `${[...seriesTypes]} chart`;
 
@@ -181,7 +180,7 @@ class XYChartComponent extends React.Component<XYChartProps> {
           role="presentation"
         >
           <dl className="echScreen-reader">
-            <dt> Chart type </dt>
+            <dt>Chart type</dt>
             <dd>{chartSeriesTypes}</dd>
           </dl>
         </canvas>

diff --git a/src/chart_types/xy_chart/renderer/dom/_screen_reader.scss b/src/chart_types/xy_chart/renderer/dom/_screen_reader.scss
@@ -1,4 +1,4 @@
-.echScreen-reader {
+.echScreenReaderOnly {
   position: absolute;
   left: -10000px;
   top: auto;

diff --git a/src/components/__snapshots__/chart.test.tsx.snap b/src/components/__snapshots__/chart.test.tsx.snap
@@ -77,7 +77,7 @@ exports[`Chart should render the legend name test 1`] = `
                       <canvas className=\\"echCanvasRenderer\\" width={150} height={200} style={{...}} role=\\"presentation\\">
                         <dl className=\\"echScreen-reader\\">
                           <dt>
-                             Chart type 
+                            Chart type
                           </dt>
                           <dd>
                             bar chart