Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brushing on small multiples doesn't consider the multiples #1070

Closed
1 task
markov00 opened this issue Mar 10, 2021 · 2 comments · Fixed by #1071
Closed
1 task

Brushing on small multiples doesn't consider the multiples #1070

markov00 opened this issue Mar 10, 2021 · 2 comments · Fixed by #1071
Assignees
@markov00
Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart released on @25.0.x released Issue released publicly

Comments

@markov00
Copy link
Member

Describe the bug
When brushing on a small multiples the following issues appear:

  • in every small multiple and brush configuration, the brush is not limited to the single trellis, but can cover multiple charts.
  • this causes a wrongly returned set of scaled values, that covers more then the current trellis extent

To Reproduce
Steps to reproduce the behavior:

  1. Goto https://codesandbox.io/s/quirky-flower-k1sst?file=/src/App.tsx
  2. Brush the chart
  3. When brushing more then one chart you start seeing the error reported on the timestamps

Expected behaviour
The brush should limit itself to the panel the brush event was started

Version (please complete the following information):

  • Elastic Charts: since small multiple feature

Errors in browser console
n/a

Kibana Cross Issues
@markov00 markov00 added bug Something isn't working kibana cross issue Has a Kibana issue counterpart labels Mar 10, 2021
@markov00 markov00 self-assigned this Mar 10, 2021
@nickofthyme nickofthyme mentioned this issue Mar 10, 2021
Merged
markov00 added a commit that referenced this issue Mar 11, 2021
@markov00
fix(brush): force brush tool per panel (#1071)
8f866fc 
This commit force the brush tool to work per panel when using small multiples. This behavior is built to works independently from the presence or absence of a small multiples configuration.
It works by forcing the brushable area to be constraint between the boundaries of the panel where the brushing event started. The brush selection doesn't move between panels and the coordinate of the mouse down event determines the limiting panel.

fix #1070
markov00 added a commit to markov00/elastic-charts that referenced this issue Mar 11, 2021
@markov00
fix(brush): force brush tool per panel (elastic#1071)
28147b8 
This commit force the brush tool to work per panel when using small multiples. This behavior is built to works independently from the presence or absence of a small multiples configuration.
It works by forcing the brushable area to be constraint between the boundaries of the panel where the brushing event started. The brush selection doesn't move between panels and the coordinate of the mouse down event determines the limiting panel.

fix elastic#1070
markov00 added a commit that referenced this issue Mar 11, 2021
@markov00
fix(brush): force brush tool per panel (#1071) [25.0.x] (#1073)
c9ac2c0 
This commit force the brush tool to work per panel when using small multiples. This behavior is built to works independently from the presence or absence of a small multiples configuration.
It works by forcing the brushable area to be constraint between the boundaries of the panel where the brushing event started. The brush selection doesn't move between panels and the coordinate of the mouse down event determines the limiting panel.

fix #1070
github-actions bot pushed a commit that referenced this issue Mar 11, 2021
@semantic-release-bot
chore(release): 25.0.4 [skip ci]
666aaa1 
## [25.0.4](v25.0.3...v25.0.4) (2021-03-11)

### Bug Fixes

* **brush:** force brush tool per panel ([#1071](#1071)) [25.0.x] ([#1073](#1073)) ([c9ac2c0](c9ac2c0)), closes [#1070](#1070)
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 25.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Mar 11, 2021
@semantic-release-bot
chore(release): 25.3.0 [skip ci]
bc1aea3 
# [25.3.0](v25.2.0...v25.3.0) (2021-03-11)

### Bug Fixes

* **brush:** force brush tool per panel ([#1071](#1071)) ([8f866fc](8f866fc)), closes [#1070](#1070)

### Features

* debug state for the heatmap chart  ([#976](#976)) ([2ae2bbc](2ae2bbc))
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 25.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Mar 11, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 25.3.0 [skip ci]
0085472 
# [25.3.0](elastic/elastic-charts@v25.2.0...v25.3.0) (2021-03-11)

### Bug Fixes

* **brush:** force brush tool per panel ([opensearch-project#1071](elastic/elastic-charts#1071)) ([61d6b7a](elastic/elastic-charts@61d6b7a)), closes [opensearch-project#1070](elastic/elastic-charts#1070)

### Features

* debug state for the heatmap chart  ([opensearch-project#976](elastic/elastic-charts#976)) ([9ba7666](elastic/elastic-charts@9ba7666))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Something isn't working kibana cross issue Has a Kibana issue counterpart released on @25.0.x released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(brush): force brush tool per panel markov00/elastic-charts
2 participants
@markov00 @nickofthyme