Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LineSeries throw warnings when using ScaleType.Log #112

Closed
sulemanof opened this issue Mar 21, 2019 · 1 comment · Fixed by #114
Closed

LineSeries throw warnings when using ScaleType.Log #112

sulemanof opened this issue Mar 21, 2019 · 1 comment · Fixed by #114
Assignees
@markov00
Labels
bug Something isn't working released Issue released publicly

Comments

@sulemanof
Copy link

Describe the bug
While setting a prop yScaleType={ScaleType.Log} to LineSeries component, get console warnings:

image

Here is an ES dataset: data.txt

To Reproduce
The code looks like:

this.props.series.map(series => (
            <LineSeries
              key={series.id}
              id={getSpecId(series.label)}
              xScaleType={ScaleType.Time}
              yScaleType={ScaleType.Log}
              xAccessor={0}
              yAccessors={[1]}
              data={series.data}
              yScaleToDataExtent={false}
            />
          ))

Expected behavior
There should not be any warning

Version (please complete the following information):

  • OS: Windows 10
  • Browser Chrome v 72.0.3626.121
  • Elastic Charts: 3.2.0
@sulemanof sulemanof added the bug Something isn't working label Mar 21, 2019
@markov00 markov00 self-assigned this Mar 22, 2019
markov00 added a commit to markov00/elastic-charts that referenced this issue Mar 22, 2019
@markov00
fix(rendering): fix rendering values <= 0 on log scale
1b8285b 
instead of throwing errors or warnings, if the user is using a log scale with a dataset with 0
values, we will hide them on the rendering of line and area charts. This fix also the defined area
of the chart

fix elastic#112, fix elastic#63
@markov00 markov00 mentioned this issue Mar 22, 2019
Merged
4 tasks
markov00 added a commit that referenced this issue Mar 26, 2019
@markov00
fix(rendering): fix rendering values <= 0 on log scale (#114)
9d7b159 
Instead of throwing errors or warnings, if the user is using a log scale with a dataset with 0
values, we will hide them on the rendering of line and area charts. This fix also the defined area
of the chart

fix #112, fix #63
@markov00 markov00 added this to the 7.1 milestone Mar 26, 2019
markov00 pushed a commit that referenced this issue Mar 26, 2019
@semantic-release-bot
chore(release): 3.4.2 [skip ci]
413e2e5 
## [3.4.2](v3.4.1...v3.4.2) (2019-03-26)

### Bug Fixes

* **rendering:** fix rendering values <= 0 on log scale ([#114](#114)) ([9d7b159](9d7b159)), closes [#112](#112) [#63](#63)
@markov00
Copy link
Member

🎉 This issue has been resolved in version 3.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Mar 26, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 3.4.2 [skip ci]
6ff06fc 
## [3.4.2](elastic/elastic-charts@v3.4.1...v3.4.2) (2019-03-26)

### Bug Fixes

* **rendering:** fix rendering values <= 0 on log scale ([opensearch-project#114](elastic/elastic-charts#114)) ([2b79877](elastic/elastic-charts@2b79877)), closes [opensearch-project#112](elastic/elastic-charts#112) [opensearch-project#63](elastic/elastic-charts#63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
bug Something isn't working released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rendering): fix rendering values <= 0 on log scale markov00/elastic-charts
2 participants
@markov00 @sulemanof