Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Legends] Discuss: hard to discover shift-click to isolate series #1339

Closed
ghudgins opened this issue Aug 25, 2021 · 8 comments · Fixed by #2418
Closed

[Legends] Discuss: hard to discover shift-click to isolate series #1339

ghudgins opened this issue Aug 25, 2021 · 8 comments · Fixed by #2418
Assignees
Labels
enhancement New feature or request Impact:Medium :legend Legend related issue

Comments

@ghudgins
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Not obvious you can shift click to "isolate" a series in a legend. Isolation is really useful if you have a dashboard visualizing many series and one of them is performing abnormally. You may want to quickly filter other visualizations to the same value.

Describe the solution you'd like
Just ideas at this point:

  • Switch the controls: consider if click-to-exclude is really the most important case (or is click-to-isolate more important...this is a discuss issue, so we should discuss.
  • Come up with a better visual option when hovering a legend series that shows a "thumb tack" and the "eye crossed off" to show there are two options on hover?
  • There's also some Kibana-level solutions around legend synchronization that we might want to consider

Describe alternatives you've considered
Today it works, it's just hard to discover. There's also some awkwardness when "un shift clicking" that results in no visual

Today's click behavior
exclude

Today's shift-click behavior
isolate

@ghudgins ghudgins added enhancement New feature or request discuss To be discussed :legend Legend related issue labels Aug 25, 2021
@ghudgins ghudgins mentioned this issue Aug 25, 2021
@ghudgins ghudgins changed the title [Legends] Discuss: hard to discover today's shift-click to isolate series [Legends] Discuss: hard to discover shift-click to isolate series Aug 25, 2021
@teresaalvarezsoler
Copy link

teresaalvarezsoler commented Feb 14, 2024

As per several user feedback click-to-isolate seems to be the expected behaviour and more important than click-to-exclude.

Solution proposal:

  1. Default behaviour should be to click-to-isolate
  2. Show a tooltip "Cmd + click to exclude" when hovering (it will need to be compatible with the tooltip that appears when labels are truncated)
image

@teresaalvarezsoler teresaalvarezsoler added Impact:Medium and removed discuss To be discussed labels Mar 8, 2024
@markov00
Copy link
Member

markov00 commented Mar 8, 2024

hey @MichaelMarcialis what should be a feasible way to implement the tooltip described by Teresa in the second proposed point?
We are using a title attribute on the list item that uses the browser's default tooltip.
EUI is not an elastic-charts direct dependency so we can't use the EUI tooltip for this and we need to build one or try to reuse the part of what we have already in the chart.

@MichaelMarcialis
Copy link

hey @MichaelMarcialis what should be a feasible way to implement the tooltip described by Teresa in the second proposed point?

My initial instinct is to say not to use a tooltip at all. Instead, we could use the existing popover menu (triggered from the right-hand action button) to display both the isolate and exclude actions. Each action could then also show the shortcut used to take that action if they prefer not to use the menu. Something like this:

shortcut

Thoughts?

@markov00
Copy link
Member

markov00 commented Mar 8, 2024

@MichaelMarcialis This definitely works for me, not sure if that menu is available everywhere, or can be disabled in specific contexts. Definitely is not part of elastic-charts so it will not apply to non-lens charts

@teresaalvarezsoler
Copy link

Thanks Michael, it looks good to me too.

Definitely is not part of elastic-charts so it will not apply to non-lens charts
I think that's fine for now.

@dej611 dej611 self-assigned this Apr 2, 2024
@teresaalvarezsoler
Copy link

teresaalvarezsoler commented Apr 5, 2024

@MichaelMarcialis now that I think twice about it, I think we may be overcomplicating that menu unnecessarily. It will be too cumbersome for users to open that menu to isolate/exclude series, don't you think? The discoverability problem to hide series can be solved just showing a tooltip when users hover (as I mentioned here) which is a pretty standard and expected behaviour. Of course you are the UX expert so you have the last decision on this :) (cc @dej611 )

@MichaelMarcialis
Copy link

@MichaelMarcialis now that I think twice about it, I think we may be overcomplicating that menu unnecessarily. It will be too cumbersome for users to open that menu to isolate/exclude series, don't you think? The discoverability problem to hide series can be solved just showing a tooltip when users hover (as I mentioned here) which is a pretty standard and expected behaviour. Of course you are the UX expert so you have the last decision on this :) (cc @dej611 )

Good question. I think the ultimate intent/hope is that users would only ever need to open that menu once before being educated about the availability of a shortcut to make it easier/faster the next time. In my experience, this feels like a fairly common pattern of accommodating the mouse-centric users while also educating those that prefer shortcuts (all while not adding visual "weight" to the idle experience). For example, Figma does a great job of doing this:

CleanShot 2024-04-09 at 16 06 01

Personally, I'd prefer we proceed with the suggested direction rather than the tooltip route, but happy to discuss further if there is a strong case to do so.

@dej611
Copy link
Contributor

dej611 commented Apr 10, 2024

Can we have an offline sync to discuss this a bit?
I see there are few options on the table and discuss it can help clear out a bit some ambiguity.

I think the decision of what a click and a SHIFT+click should do, and how to provide feedback to the user can have a big impact on the charts library implementation depending on which route we're going into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Impact:Medium :legend Legend related issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants