-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Legends] Discuss: hard to discover shift-click to isolate series #1339
Comments
hey @MichaelMarcialis what should be a feasible way to implement the tooltip described by Teresa in the second proposed point? |
My initial instinct is to say not to use a tooltip at all. Instead, we could use the existing popover menu (triggered from the right-hand action button) to display both the isolate and exclude actions. Each action could then also show the shortcut used to take that action if they prefer not to use the menu. Something like this: Thoughts? |
@MichaelMarcialis This definitely works for me, not sure if that menu is available everywhere, or can be disabled in specific contexts. Definitely is not part of elastic-charts so it will not apply to non-lens charts |
Thanks Michael, it looks good to me too.
|
@MichaelMarcialis now that I think twice about it, I think we may be overcomplicating that menu unnecessarily. It will be too cumbersome for users to open that menu to isolate/exclude series, don't you think? The discoverability problem to hide series can be solved just showing a tooltip when users hover (as I mentioned here) which is a pretty standard and expected behaviour. Of course you are the UX expert so you have the last decision on this :) (cc @dej611 ) |
Good question. I think the ultimate intent/hope is that users would only ever need to open that menu once before being educated about the availability of a shortcut to make it easier/faster the next time. In my experience, this feels like a fairly common pattern of accommodating the mouse-centric users while also educating those that prefer shortcuts (all while not adding visual "weight" to the idle experience). For example, Figma does a great job of doing this: Personally, I'd prefer we proceed with the suggested direction rather than the tooltip route, but happy to discuss further if there is a strong case to do so. |
Can we have an offline sync to discuss this a bit? I think the decision of what a click and a SHIFT+click should do, and how to provide feedback to the user can have a big impact on the charts library implementation depending on which route we're going into. |
Is your feature request related to a problem? Please describe.
Not obvious you can shift click to "isolate" a series in a legend. Isolation is really useful if you have a dashboard visualizing many series and one of them is performing abnormally. You may want to quickly filter other visualizations to the same value.
Describe the solution you'd like
Just ideas at this point:
Describe alternatives you've considered
Today it works, it's just hard to discover. There's also some awkwardness when "un shift clicking" that results in no visual
Today's click behavior
Today's shift-click behavior
The text was updated successfully, but these errors were encountered: