Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Band area chart #144

Closed
3 tasks done
markov00 opened this issue Apr 2, 2019 · 1 comment · Fixed by #157
Closed
3 tasks done

Add Band area chart #144

markov00 opened this issue Apr 2, 2019 · 1 comment · Fixed by #157
Assignees
Labels
enhancement New feature or request :new chart type New chart type related feature request released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Apr 2, 2019

Is your feature request related to a problem? Please describe.
Add a band area chart like in the following screenshot.
TSVB currently has this function when using percentile aggregation in band mode.
6a00e554d9fb998833014e87c5dded970d

Describe the solution you'd like
The area chart specification can be extended to add a y0 accessor to specify the minimum value of the area chart if not zero. This will be used to compute the band.

Describe alternatives you've considered
n/a

Additional context
n/a

Kibana Cross Issues
n/a

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@markov00 markov00 added enhancement New feature or request :new chart type New chart type related feature request labels Apr 2, 2019
@markov00 markov00 mentioned this issue Apr 2, 2019
93 tasks
@markov00 markov00 added this to the 7.1 milestone Apr 2, 2019
@markov00 markov00 self-assigned this Apr 5, 2019
@markov00 markov00 mentioned this issue Apr 8, 2019
5 tasks
markov00 added a commit to markov00/elastic-charts that referenced this issue Apr 10, 2019
Add a `y0Accessor` prop for each series to enable the possibility to add a lower limit to area and
bars.

close elastic#144
markov00 added a commit that referenced this issue Apr 11, 2019
This PR adds a `y0Accessors` prop for each `SeriesSpec`: this property can be used to describe a dataset with bands ( with a min and max value for each data point).
It's mainly used for with `AreaSeries` to describe a bounded area chart, bounded on the y axis. The  `y0` value, is usually a lower value than the `y1`, it will be rendered perpendicularly to the `y1`  point. On a standard area chart, the `y0` value usually correspond to `0` or to the previous value in the stack. In a band-area chart, the `y0` can be any value below the `y1` value.
It can also be applied to bar charts, with some limitations as described below. On a barchart, the `y0` value is the bottom edge of the bar.
On a stacked bar/area chart a series with a `y0Accessor` will be stacked on top of the below series stacking the below series `y1` value with the band series `y0` value. This means that if the below series at a point X has an height of `10`, and the bound series has the following values: `y0: 2, y1: 5` the resulting chart will push the bound series to the top starting using the following values: `y0:12, y1: 15`. The `IndexedGeometry` object is also refactored. To limit amount of redundant code/memory object we used the same `Geometry` elements used on the highlight/hover process.
The structure of `IndexedGeometry` is slightly changed, to avoid duplicate values and to simplify tooltip formatting when rendering either y1 and y0 values.  
I've currently removed from the `indexedGeometries` map all geometry with `null` values on `y1`. This leads to a minor problem: we are not showing any tooltip on that interval, the tooltip of the crosshair is never shown.

close #144
markov00 pushed a commit that referenced this issue Apr 11, 2019
# [3.10.0](v3.9.0...v3.10.0) (2019-04-11)

### Features

* add band area chart ([#157](#157)) ([a9307ef](a9307ef)), closes [#144](#144)
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Apr 11, 2019
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request :new chart type New chart type related feature request released Issue released publicly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant