Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose fit function style #1489

Closed
markov00 opened this issue Nov 19, 2021 · 0 comments · Fixed by #1505
Closed

Expose fit function style #1489

markov00 opened this issue Nov 19, 2021 · 0 comments · Fixed by #1505
Assignees
Labels
:data Data/series/scales related issue enhancement New feature or request :styling Styling related issue :xy Bar/Line/Area chart related

Comments

@markov00
Copy link
Member

Describe the solution you'd like
The user may desire to style differently the fitted values depending on their use cases.
We currently hardcoded some values, like the dashed style and the opacity value of the area.
We should expose, through the theme, a way to add a custom style for those rendered lines/areas/points.

Describe alternatives you've considered
We probably don't want to include a new fit function to linearly connect all points with a straight line and no area opacity.
Exposing the style is way come useful and the user can also reuse that style in different fitting functions.

@markov00 markov00 added enhancement New feature or request :data Data/series/scales related issue :styling Styling related issue :xy Bar/Line/Area chart related labels Nov 19, 2021
@markov00 markov00 self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:data Data/series/scales related issue enhancement New feature or request :styling Styling related issue :xy Bar/Line/Area chart related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant