-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose style for interpolation fit functions #1505
Merged
markov00
merged 18 commits into
elastic:master
from
markov00:2021_11_25-expose_fit_style
Dec 1, 2021
Merged
feat: expose style for interpolation fit functions #1505
markov00
merged 18 commits into
elastic:master
from
markov00:2021_11_25-expose_fit_style
Dec 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
:data
Data/series/scales related issue
:xy
Bar/Line/Area chart related
:theme
labels
Nov 25, 2021
nickofthyme
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I just made two comments on the api
rshen91
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes LGTM - tested locally
nickofthyme
approved these changes
Dec 1, 2021
This was referenced Dec 3, 2021
nickofthyme
pushed a commit
that referenced
this pull request
Dec 9, 2021
# [40.2.0](v40.1.0...v40.2.0) (2021-12-09) ### Bug Fixes * **partition:** linkLabel textColor override ([#1498](#1498)) ([3013310](3013310)) * **waffle:** use descend sortPredicate by default ([#1510](#1510)) ([763e2e3](763e2e3)) * **xy:** stacked polarity ([#1502](#1502)) ([920666a](920666a)), closes [#1280](#1280) ### Features * **xy:** expose style for interpolation fit functions ([#1505](#1505)) ([3071457](3071457))
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR exposes the style options for the currently available interpolation fit functions.
In particular:
area
path of an interpolated area can be customized as:rendered with:
line
path can be customized with:rendered with:
Details
The style is exposed through the
LineSeriesStyle
and theAreaSeriesStyle
so it can be configured globally and/or configured per series.I take the chance to refactor a bit the code, removing some optional arguments and reversing small logic to improve code readability.
cc @elastic/eui-design
Please double-check the
theme
property. We basically just expose the currently used style without breaking changes.The visualization editor will take care of handling and applying a different style when requested by the user (generally they are just requesting to show a straight line and a filled area without any differences between the interpolated line/area and the original line/area created with the dataset.
Issues
fix #1489
Checklist
:xy
,:partition
):interactions
,:axis
):theme
label has been added and the@elastic/eui-design
team has been pinged when there areTheme
API changescloses #123
,fixes #123
)packages/charts/src/index.ts
dark
,light
,eui-dark
&eui-light