Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting configuration changes #702

Closed
3 of 4 tasks
nickofthyme opened this issue Jun 10, 2020 · 2 comments · Fixed by #764
Closed
3 of 4 tasks

Linting configuration changes #702

nickofthyme opened this issue Jun 10, 2020 · 2 comments · Fixed by #764
Labels
:ci enhancement New feature or request meta ...meta issue released Issue released publicly

Comments

@nickofthyme
Copy link
Collaborator

nickofthyme commented Jun 10, 2020

List of anomalies

  • conflicting rules typescript-eslint/member-ordering and react/sort-comp
  • max-len rule not auto fixable.
  • Switch back to prettier for indenting
  • eslint formatOnSave vscode configuration (eslint/indent vs eslint/prettier)
@nickofthyme nickofthyme added enhancement New feature or request meta ...meta issue :ci labels Jun 10, 2020
@markov00
Copy link
Member

markov00 commented Jun 18, 2020

I think we could split the configuration in two:

  • one with fewer restrictions, fewer warnings and fewer errors that we can run quickly and can run unnoticed on every file save
  • one with more restriction that one ever X someone can pick up and correct the code in a single PR

I'd like to note also that we should consider the running speeds of each rules using:
TIMING=1 yarn lint
this will give us a better idea of the time spent on each rule and we can disable long-running rules that are not strictly necessary.
This is an example of the output:

Rule                                    | Time (ms) | Relative
:---------------------------------------|----------:|--------:
import/no-restricted-paths              | 15176.153 |    28.1%
@typescript-eslint/no-floating-promises | 11292.930 |    20.9%
import/namespace                        |  5147.231 |     9.5%
indent                                  |  2864.589 |     5.3%
@typescript-eslint/no-misused-promises  |  2157.196 |     4.0%
react/no-unknown-property               |  1325.769 |     2.5%
react/prefer-stateless-function         |  1045.864 |     1.9%
react/void-dom-elements-no-children     |   692.260 |     1.3%
@typescript-eslint/unbound-method       |   689.988 |     1.3%
import/no-unresolved                    |   611.144 |     1.1%

@markov00
Copy link
Member

🎉 This issue has been resolved in version 21.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ci enhancement New feature or request meta ...meta issue released Issue released publicly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants