ci: add prettier back 🎉

[nickofthyme]

Summary

🚧 Waiting for #751 before merging 🚧

closes #702

• conflicting rules typescript-eslint/member-ordering and react/sort-comp
• max-len rule not auto fixable.
• Switch back to prettier for indenting
• eslint formatOnSave vscode configuration (eslint/indent vs eslint/prettier)
• split out high load rules to only run on yarn lint

my vscode settings.json config for eslint is below. Some of which is not needed for ec like vue but doesn't hurt anything.

{
  "eslint.codeAction.showDocumentation": {
    "enable": true
  },
  "eslint.codeAction.disableRuleComment": {
    "enable": true,
    "location": "separateLine"
  },
  "eslint.validate": [
    "javascript",
    "javascriptreact",
    "vue",
    "html",
    "typescript",
    "typescriptreact",
  ],
}

full settings options available here

Removed most cpu intensive rules from dev config. @typescript-eslint/* rules seem to lump together, no matter how many I remove another @typescript-eslint/* rule will show up at the top of the list. Current excluded rules are:

• import/no-restricted-paths
• import/namespace

Rule                                    | Time (ms) | Relative
:---------------------------------------|----------:|--------:
prettier/prettier                       | 15441.700 |    36.1%
@typescript-eslint/no-floating-promises |  9862.220 |    23.1%
@typescript-eslint/no-misused-promises  |  1964.450 |     4.6%
react/no-unknown-property               |  1469.325 |     3.4%
import/no-unresolved                    |  1135.063 |     2.7%
react/prefer-stateless-function         |  1037.916 |     2.4%
react/void-dom-elements-no-children     |   662.293 |     1.5%
@typescript-eslint/unbound-method       |   623.038 |     1.5%
react/no-deprecated                     |   482.789 |     1.1%
react/no-direct-mutation-state          |   475.650 |     1.1%

[codecov-commenter]

Codecov Report

Merging #764 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   74.45%   74.45%           
=======================================
  Files         269      269           
  Lines        9303     9303           
  Branches     1936     1936           
=======================================
  Hits         6927     6927           
  Misses       2371     2371           
  Partials        5        5           

Flag	Coverage Δ
#unittests	74.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2e35d...e8a47c9. Read the comment docs.

[markov00]

LGTM!

[markov00]

🎉 This PR is included in version 21.0.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀