Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crosshair and vertical/horizontal cursors #80

Closed
2 of 5 tasks
markov00 opened this issue Feb 28, 2019 · 1 comment · Fixed by #96
Closed
2 of 5 tasks

Crosshair and vertical/horizontal cursors #80

markov00 opened this issue Feb 28, 2019 · 1 comment · Fixed by #96
Assignees
@markov00
Labels
enhancement New feature or request :interactions Interactions related issue kibana cross issue Has a Kibana issue counterpart released Issue released publicly

Comments

@markov00
Copy link
Member

markov00 commented Feb 28, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
Add the possibility to switch between simple element tooltip to multi/element tooltips like vertical or horizontal cursors or crosshair.
screenshot 2019-02-28 at 15 24 02
Describe the solution you'd like

The user/developer can select the type of tooltip that's better conforms for the chart use to enable the following possibilities:

Describe alternatives you've considered

Various solutions can be applied:

  • remove the existing listeners to graphic elements and use directly mouse coordinates to mapping series data values getting series values from inverted x and y scales or use some spatial index for faster searches like https://github.com/mourner/flatbush
  • draw a hidden layer of grouped elements with listener attached to it (can be slow and can only works on vertical and horizontal cursors.

design note: the tooltip could be crowded specially with multiple splitted series.
extra: this can solve the following issue: #58

Additional context

TVSB, charts used by Stack Monitor and any other chart that use react-vis in kibana currently has the possibility to include a vertical cursor on the chart instead of the tooltip.

Kibana Cross Issues

Checklist

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@markov00 markov00 added the enhancement New feature or request label Feb 28, 2019
@markov00 markov00 changed the title [interactions] crosshair and vertical/horizontal cursors [interactions] Crosshair and vertical/horizontal cursors Feb 28, 2019
This was referenced Feb 28, 2019
Closed
Closed
Closed
@markov00 markov00 added this to the 7.1 milestone Feb 28, 2019
@markov00 markov00 changed the title [interactions] Crosshair and vertical/horizontal cursors Crosshair and vertical/horizontal cursors Feb 28, 2019
@markov00 markov00 added the :interactions Interactions related issue label Feb 28, 2019
@markov00 markov00 self-assigned this Mar 6, 2019
@markov00 markov00 added the kibana cross issue Has a Kibana issue counterpart label Mar 8, 2019
@markov00 markov00 mentioned this issue Mar 8, 2019
Merged
21 tasks
markov00 added a commit that referenced this issue Mar 22, 2019
@markov00
feat(interactions): crosshair
5ddd1a8 
Removed any listeners from the canvas elements. Using a map for each geometry on the chart: mappings x value and any relative Y values associated. We invert the mouse coordinates using the xScale to get the right X key to use on that map. This increase the performance on highly/medium dense charts. Two new props are added to the `Settings` specs: `tooltipType` to specify the tooltip type (vertical cursor, crosshair, follow, none) and the `tooltipSnap` to snap the cursor to the grid for linear charts.

close #80, close #58, close #88
markov00 pushed a commit that referenced this issue Mar 22, 2019
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
d498484 
# [3.3.0](v3.2.0...v3.3.0) (2019-03-22)

### Features

* **interactions:** crosshair ([5ddd1a8](5ddd1a8)), closes [#80](#80) [#58](#58) [#88](#88)
@markov00
Copy link
Member Author

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Mar 22, 2019
@markov00 markov00 mentioned this issue Apr 4, 2019
Closed
19 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this issue Feb 10, 2022
@semantic-release-bot
chore(release): 3.3.0 [skip ci]
8648b9d 
# [3.3.0](elastic/elastic-charts@v3.2.0...v3.3.0) (2019-03-22)

### Features

* **interactions:** crosshair ([1f0cd2e](elastic/elastic-charts@1f0cd2e)), closes [opensearch-project#80](elastic/elastic-charts#80) [opensearch-project#58](elastic/elastic-charts#58) [opensearch-project#88](elastic/elastic-charts#88)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markov00 markov00

Labels
enhancement New feature or request :interactions Interactions related issue kibana cross issue Has a Kibana issue counterpart released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(interaction): crosshair markov00/elastic-charts
1 participant
@markov00