-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(partition): small multiples #1076
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1076 +/- ##
==========================================
+ Coverage 71.77% 71.98% +0.20%
==========================================
Files 381 397 +16
Lines 11743 12229 +486
Branches 2512 2636 +124
==========================================
+ Hits 8429 8803 +374
- Misses 3299 3387 +88
- Partials 15 39 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
b0b1240
to
6da2336
Compare
…trude into margin
…ty chart due to all zero slices
8ff0f95
to
30e3241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/chart_types/partition_chart/state/selectors/drilldown_active.ts
Outdated
Show resolved
Hide resolved
The vertical offsetting is improved to avoid cropping with a zero outer panel pad: cb12f05 and the Theme iteration (follow-up PR) will use the Theme font and padding specs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging on green.
Followup PR:
- fix hierarchical legend
…tition-4 # Conflicts: # api/charts.api.md
# [26.0.0](v25.4.0...v26.0.0) (2021-03-23) ### Features * **partition:** small multiples ([#1076](#1076)) ([282082b](282082b)) ### BREAKING CHANGES * **partition:** clarifies the inner/outer padding notation `<SmallMultiples style={{horizontalPanelPadding, verticalPanelPadding}}` from `[outer, inner]` to `{outer, inner}`—they still have the same effect
🎉 This PR is included in version 26.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [26.0.0](elastic/elastic-charts@v25.4.0...v26.0.0) (2021-03-23) ### Features * **partition:** small multiples ([opensearch-project#1076](elastic/elastic-charts#1076)) ([9b7f2f6](elastic/elastic-charts@9b7f2f6)) ### BREAKING CHANGES * **partition:** clarifies the inner/outer padding notation `<SmallMultiples style={{horizontalPanelPadding, verticalPanelPadding}}` from `[outer, inner]` to `{outer, inner}`—they still have the same effect
Summary
Small multiples for partition charts
index
): multiple<Partition>
specs under<Chart>
WIPinnerIndex
): breakdown of a<Partition>
spec along its first partitioning layergetChartIdSelector
s in place of previous repeated(state) => state.chartId
s (earlier unrelated feedback by Nick)PanelPlacement
,RelativeMargins
containerBackgroundColor
ingetShapeViewModel
(no longer optional)[outer, inner]
to{outer, inner}
Warning, will likely do
push -f
while it's WIPChecklist
Delete any items that are not applicable to this PR.
src/index.ts
(and stories only import from../src
except for test data & storybook)margin
and adding title info to the tooltip<GroupBy>
...
if it doesn't fit horizontally