Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(partitions): small multipies events pass on smAccessorValue #1106

Merged
merged 4 commits into from
Apr 6, 2021

Conversation

monfera
Copy link
Contributor

@monfera monfera commented Apr 6, 2021

Summary

Small multipies events now pass on smAccessorValue, which is the unformatted value returned by the by function in <GroupBy>.

See the Actions tab in http://localhost:9001/?path=/story/small-multiples-alpha--sunbursts and hover or click on slices.

image

Checklist

Delete any items that are not applicable to this PR.

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • This was checked for cross-browser compatibility
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@monfera monfera added :partition Partition/PieChart/Donut/Sunburst/Treemap chart related :small multiples Small multiples/trellising related issues labels Apr 6, 2021
@codecov-io
Copy link

codecov-io commented Apr 6, 2021

Codecov Report

Merging #1106 (d6ebfba) into master (88d71ff) will increase coverage by 0.55%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1106      +/-   ##
==========================================
+ Coverage   71.81%   72.36%   +0.55%     
==========================================
  Files         381      397      +16     
  Lines       11918    12232     +314     
  Branches     2602     2650      +48     
==========================================
+ Hits         8559     8852     +293     
- Misses       3328     3347      +19     
- Partials       31       33       +2     
Flag Coverage Δ
unittests 71.94% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._types/goal_chart/state/selectors/picked_shapes.ts 26.31% <ø> (ø)
...es/partition_chart/layout/types/viewmodel_types.ts 87.50% <ø> (ø)
...ypes/partition_chart/renderer/canvas/partition.tsx 31.46% <ø> (ø)
...hart_types/partition_chart/state/selectors/tree.ts 100.00% <ø> (+35.89%) ⬆️
...t_types/wordcloud/state/selectors/picked_shapes.ts 20.00% <ø> (ø)
src/specs/group_by.ts 100.00% <ø> (ø)
src/specs/settings.tsx 90.32% <ø> (ø)
.../partition_chart/layout/viewmodel/picked_shapes.ts 100.00% <100.00%> (ø)
...ypes/partition_chart/layout/viewmodel/viewmodel.ts 85.08% <100.00%> (ø)
...ypes/partition_chart/state/selectors/geometries.ts 83.45% <100.00%> (+6.47%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88d71ff...d6ebfba. Read the comment docs.

Copy link
Collaborator

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM!

@monfera
Copy link
Contributor Author

monfera commented Apr 6, 2021

jenkins test this please

@monfera monfera merged commit a3234fe into elastic:master Apr 6, 2021
nickofthyme pushed a commit that referenced this pull request Apr 13, 2021
# [28.1.0](v28.0.1...v28.1.0) (2021-04-13)

### Bug Fixes

* **legend:** sizing for short labels with scrollbar ([#1115](#1115)) ([6e1f223](6e1f223))
* **xy:** negative bar highlight and click ([#1109](#1109)) ([ec17cb2](ec17cb2)), closes [#1100](#1100)

### Features

* **a11y:** improve chart figure ([#1104](#1104)) ([815cf39](815cf39))
* **partition:** order slices and sectors ([#1112](#1112)) ([74df29b](74df29b))
* **partitions:** small multipies events pass on smAccessorValue ([#1106](#1106)) ([a3234fe](a3234fe))
* **xy:** optionally rounds the domain to nice values ([#1087](#1087)) ([f644cc4](f644cc4))
* **xy:** specify pixel and ratio width for bars ([#1114](#1114)) ([58de413](58de413))
* mosaic ([#1113](#1113)) ([64bdd88](64bdd88))
@nickofthyme
Copy link
Collaborator

🎉 This PR is included in version 28.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Apr 13, 2021
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:partition Partition/PieChart/Donut/Sunburst/Treemap chart related released Issue released publicly :small multiples Small multiples/trellising related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants