Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xy): negative bar highlight and click (#1109) [25.0.x] #1126

Merged
merged 3 commits into from
Apr 20, 2021

Conversation

nickofthyme
Copy link
Collaborator

Backports the following commits to 25.0.x:

fix elastic#1100
# Conflicts:
#	integration/tests/__image_snapshots__/all-test-ts-baseline-visual-tests-for-all-stories-interactions-bar-clicks-and-hovers-visually-looks-correct-1-snap.png
#	src/chart_types/xy_chart/rendering/rendering.bars.test.ts
#	src/chart_types/xy_chart/state/chart_state.interactions.test.ts
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (25.0.x@b2a69f2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             25.0.x    #1126   +/-   ##
=========================================
  Coverage          ?   73.64%           
=========================================
  Files             ?      379           
  Lines             ?    11552           
  Branches          ?     2487           
=========================================
  Hits              ?     8507           
  Misses            ?     3023           
  Partials          ?       22           
Flag Coverage Δ
unittests 73.23% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a69f2...a703c0f. Read the comment docs.

@markov00 markov00 self-requested a review April 20, 2021 16:14
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, tested locally and I don't see any issues

src/chart_types/xy_chart/rendering/bars.ts Outdated Show resolved Hide resolved
Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
@nickofthyme nickofthyme merged commit 95ac3ea into elastic:25.0.x Apr 20, 2021
@nickofthyme nickofthyme deleted the backport/25.0.x/pr-1109 branch April 20, 2021 18:05
github-actions bot pushed a commit that referenced this pull request Apr 20, 2021
## [25.0.6](v25.0.5...v25.0.6) (2021-04-20)

### Bug Fixes

* **xy:** negative bar highlight and click [25.0.x] ([#1126](#1126)) ([95ac3ea](95ac3ea))
@nickofthyme
Copy link
Collaborator Author

🎉 This PR is included in version 25.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants