Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: scale improvements #1383

Merged
merged 79 commits into from
Sep 22, 2021
Merged

refactor: scale improvements #1383

merged 79 commits into from
Sep 22, 2021

Commits on Sep 17, 2021

  1. test: undefined baseline with granular domain override

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    63a8d02 View commit details
    Browse the repository at this point in the history

  2. fix: ensure at least two array elements

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    d31d2e0 View commit details
    Browse the repository at this point in the history

  3. test: restore singleton undefined for now

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    63dad76 View commit details
    Browse the repository at this point in the history

  4. fix: removing unnecessary let

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    6c6185d View commit details
    Browse the repository at this point in the history

  5. test: typescript four point four

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    6a5a69e View commit details
    Browse the repository at this point in the history

  6. refactor: enjoying typescript four point four

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    6ab43ac View commit details
    Browse the repository at this point in the history

  7. refactor: yielding a true or false literal can always be simplified

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    08838a9 View commit details
    Browse the repository at this point in the history

  8. chore: linter appeasement

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    5d12a2a View commit details
    Browse the repository at this point in the history

  9. test: removing more scale assertions 01

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    abfd291 View commit details
    Browse the repository at this point in the history

  10. test: removing more scale assertions 02

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    5a1b349 View commit details
    Browse the repository at this point in the history

  11. test: relax a type for truthfulness as strings do also occur

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    ae9b210 View commit details
    Browse the repository at this point in the history

  12. test: removing more scale assertions 03

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    79fad38 View commit details
    Browse the repository at this point in the history

  13. test: removing all any from scale_band.ts

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    16e470a View commit details
    Browse the repository at this point in the history

  14. test: removing all any from scale_continuous.ts

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    276c7cf View commit details
    Browse the repository at this point in the history

  15. test: removing an any and a union type

    @monfera
    monfera committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    2ed8e58 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2021

  1. fix: removing all coercive equal from our code

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    8a4dfe5 View commit details
    Browse the repository at this point in the history

  2. fix: removing all coercive not equal

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    5640e5a View commit details
    Browse the repository at this point in the history

  3. fix: preventing future coercive equal and unequal

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    5da6339 View commit details
    Browse the repository at this point in the history

  4. refactor: drive by simplification

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    54cb818 View commit details
    Browse the repository at this point in the history

  5. refactor: reduce algorithmic complexity somewhat

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    49f799e View commit details
    Browse the repository at this point in the history

  6. refactor: simpler coalescing

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    97d09aa View commit details
    Browse the repository at this point in the history

  7. refactor: a let removed

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    b24c588 View commit details
    Browse the repository at this point in the history

  8. refactor: mergeYCustomDomainsByGroupId

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    b06bf2d View commit details
    Browse the repository at this point in the history

  9. refactor: redefine boundedness

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    16e19b0 View commit details
    Browse the repository at this point in the history

  10. refactor: mergeYCustomDomainsByGroupId 2

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    e8e5c20 View commit details
    Browse the repository at this point in the history

  11. refactor: mergeYCustomDomainsByGroupId 3

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    b6f3839 View commit details
    Browse the repository at this point in the history

  12. refactor: topple some typescript jenga

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    d419c3c View commit details
    Browse the repository at this point in the history

  13. refactor: remove no longer expressive utils

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    276a5d9 View commit details
    Browse the repository at this point in the history

  14. refactor: convertXScaleTypes

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    bb3053b View commit details
    Browse the repository at this point in the history

  15. refactor: convertXScaleTypes 2

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    a1ca96a View commit details
    Browse the repository at this point in the history

  16. refactor: removed an overly lightweight util

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    4fb6ff1 View commit details
    Browse the repository at this point in the history

  17. refactor: simplified the return value for degenerate cases

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    9329c70 View commit details
    Browse the repository at this point in the history

  18. refactor: convertXScaleTypes 3

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    5d82166 View commit details
    Browse the repository at this point in the history

  19. refactor: convertXScaleTypes 4 - mandatory tz yield

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    2d1ca1f View commit details
    Browse the repository at this point in the history

  20. refactor: remove light and distant abstraction

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    82b082b View commit details
    Browse the repository at this point in the history

  21. fix: no more any in computeContinuousDataDomain

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    c4f4037 View commit details
    Browse the repository at this point in the history

  22. fix: no more explicit and implicit any in computeOrdinalDataDomain

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    0ccf5b1 View commit details
    Browse the repository at this point in the history

  23. fix: no more param optionality or zero length if

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    10a7b38 View commit details
    Browse the repository at this point in the history

  24. test: killing some optionalities

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    d7429fc View commit details
    Browse the repository at this point in the history

  25. chore: refactor constrainPadding

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    c6a2aa3 View commit details
    Browse the repository at this point in the history

  26. chore: refactor getPaddedDomain

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    fcd45d0 View commit details
    Browse the repository at this point in the history

  27. chore: refactor getPaddedDomain 2 - special case removal

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    53f1b9d View commit details
    Browse the repository at this point in the history

  28. chore: warning text cleanup

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    e7e288b View commit details
    Browse the repository at this point in the history

  29. refactor: coerceYScaleTypes 1

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    0acc6b0 View commit details
    Browse the repository at this point in the history

  30. refactor: coerceYScaleTypes 2

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    46563c3 View commit details
    Browse the repository at this point in the history

  31. refactor: coerceYScaleTypes 3

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    69a7d41 View commit details
    Browse the repository at this point in the history

  32. refactor: coerceYScaleTypes 4

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    209c9f6 View commit details
    Browse the repository at this point in the history

  33. refactor: for of idiom in computeYDomain

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    9219ceb View commit details
    Browse the repository at this point in the history

  34. chore: no need for optionality

    @monfera
    monfera committed Sep 19, 2021
    Configuration menu
    Copy the full SHA
    1ab9a78 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. chore: remove planned code change comments

    @monfera
    monfera committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    d173297 View commit details
    Browse the repository at this point in the history

  2. chore: pick props in type sig and remove X axis originated or obvious… 

    … code explainer comments
    @monfera
    monfera committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    b80bb22 View commit details
    Browse the repository at this point in the history

  3. fix: more any removal

    @monfera
    monfera committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    7711a63 View commit details
    Browse the repository at this point in the history

  4. chore: exempt var names centrally ht Nick

    @monfera
    monfera committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    7563e07 View commit details
    Browse the repository at this point in the history

  5. chore: no await ht Nick

    @monfera
    monfera committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    9398aad View commit details
    Browse the repository at this point in the history

  6. chore: undone exemption workaround ht Nick

    @monfera
    monfera committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    ba1a983 View commit details
    Browse the repository at this point in the history

  7. Revert "chore: no await ht Nick" 

    This reverts commit 9398aad
    @monfera
    monfera committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    3f571d9 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/master' into time-axis-06

    @monfera
    monfera committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    f5a9e39 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. refactor: eq neq optimizations 01

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    2a71e74 View commit details
    Browse the repository at this point in the history

  2. refactor: eq neq optimizations 02

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    43a2750 View commit details
    Browse the repository at this point in the history

  3. refactor: eq neq optimizations 03

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    6600695 View commit details
    Browse the repository at this point in the history

  4. refactor: eq neq optimizations 04 

    Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
    @monfera @markov00
    monfera and markov00 authored Sep 21, 2021
    Configuration menu
    Copy the full SHA
    c1822f8 View commit details
    Browse the repository at this point in the history

  5. chore: no longer async 

    Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
    @monfera @nickofthyme
    monfera and nickofthyme authored Sep 21, 2021
    Configuration menu
    Copy the full SHA
    b3a9c7e View commit details
    Browse the repository at this point in the history

  6. chore: no longer async part 2

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    2c877eb View commit details
    Browse the repository at this point in the history

  7. refactor: eq neq optimizations 04 part 2

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    e61c7eb View commit details
    Browse the repository at this point in the history

  8. chore: remove duplication 

    Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
    @monfera @nickofthyme
    monfera and nickofthyme authored Sep 21, 2021
    Configuration menu
    Copy the full SHA
    cea8e19 View commit details
    Browse the repository at this point in the history

  9. chore: remove eslint exemption 

    Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
    @monfera @nickofthyme
    monfera and nickofthyme committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    3f44bd6 View commit details
    Browse the repository at this point in the history

  10. chore: remove eslint exemption 

    Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
    @monfera @nickofthyme
    monfera and nickofthyme committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    854ea38 View commit details
    Browse the repository at this point in the history

  11. test: remove overtyping 

    Co-authored-by: Nick Partridge <nick.ryan.partridge@gmail.com>
    @monfera @nickofthyme
    monfera and nickofthyme committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    0de55eb View commit details
    Browse the repository at this point in the history

  12. test: remove overtyping update

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    604a1e0 View commit details
    Browse the repository at this point in the history

  13. refactor: simpler uniqueValues 

    Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
    @monfera @markov00
    monfera and markov00 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    820f3fd View commit details
    Browse the repository at this point in the history

  14. refactor: eq neq optimizations 05 - just comments and minor reorg

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    908a7f8 View commit details
    Browse the repository at this point in the history

  15. chore: linter wants one line

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    9dd03e1 View commit details
    Browse the repository at this point in the history

  16. refactor: eq neq optimizations 06

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    7cdd7a9 View commit details
    Browse the repository at this point in the history

  17. refactor: eq neq optimizations 07

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    78342e3 View commit details
    Browse the repository at this point in the history

  18. refactor: eq neq optimizations 08

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    6f8bf4c View commit details
    Browse the repository at this point in the history

  19. refactor: eq neq optimizations 09

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    23513e2 View commit details
    Browse the repository at this point in the history

  20. fix: simplification regression

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    2a69ec5 View commit details
    Browse the repository at this point in the history

  21. test: yield false and simplify type

    @monfera
    monfera committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    e532321 View commit details
    Browse the repository at this point in the history

  22. chore: remove unused try/catch

    @nickofthyme
    nickofthyme committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    8a90a96 View commit details
    Browse the repository at this point in the history