chore: attempt deep defaults in spec factory #1399
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at deep defaults.
Findings:
upsertSpec
function which is not idea.domain
having partial keys. So either I make the wholedomain
partial on the spec causing type checks everywhere. Or we somehow find a way to type which props are objects whose keys can be deep and values can be partials.All in all this really hurt my brain and I think it's a future consideration when we separate the final spec types from the props the user must defined which could differ. But currently I think this is more effort than it is worth.