Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xy): remove pointer cursor for onElementOver #1493

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

rshen91
Copy link
Contributor

@rshen91 rshen91 commented Nov 19, 2021

Summary

The pointer cursor will not be used in over element actions to avoid misleading users.

Issues

Closes #1437

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • Visual changes have been tested with all available themes including dark, light, eui-dark & eui-light

@rshen91 rshen91 added the :interactions Interactions related issue label Nov 23, 2021
@rshen91 rshen91 marked this pull request as ready for review November 23, 2021 16:14
@rshen91 rshen91 requested review from markov00 and nickofthyme and removed request for markov00 November 23, 2021 16:15
@rshen91 rshen91 changed the title fix(xy): remove pointer for onElementOver fix(xy): remove pointer cursor for onElementOver Nov 23, 2021
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rshen91 rshen91 merged commit bf95dbc into elastic:master Nov 24, 2021
@rshen91 rshen91 deleted the elementClick branch November 24, 2021 14:03
nickofthyme pushed a commit that referenced this pull request Dec 1, 2021
# [40.1.0](v40.0.0...v40.1.0) (2021-12-01)

### Bug Fixes

* **deps:** update dependency @elastic/eui to ^41.3.0 ([#1506](#1506)) ([d364cc0](d364cc0))
* remove pointer for onElementOver ([#1493](#1493)) ([bf95dbc](bf95dbc))
* **deps:** update dependency @elastic/eui to ^41.2.1 ([#1494](#1494)) ([1c32f82](1c32f82))

### Features

* expose computeRatioByGroups fn ([#1495](#1495)) ([65f4886](65f4886))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:interactions Interactions related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactions: onElementClick or onElementOver
2 participants