Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal): add valueFormatter for tooltip #1529

Merged
merged 13 commits into from
Jan 5, 2022
Merged

feat(goal): add valueFormatter for tooltip #1529

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
85c1743
feat: add valueFormatter for tooltip
rshen91 Dec 17, 2021
9cc4031
Merge remote-tracking branch 'upstream/master' into gauge-tooltip
rshen91 Dec 27, 2021
d41cb16
test: add vrt for tooltip value formatter
rshen91 Dec 27, 2021
c7af8fd
fix: code review
rshen91 Dec 27, 2021
c22c249
test: revert chart snap test
rshen91 Dec 27, 2021
61833ea
refactor: tooltipValueFormatter
rshen91 Dec 27, 2021
a62f03d
test: update centralMajor in story
rshen91 Dec 30, 2021
bb02630
fix: update charts api
rshen91 Dec 30, 2021
2e998d3
test: update goal stories with centralMajor
rshen91 Dec 30, 2021
aa446cb
Merge remote-tracking branch 'upstream/master' into gauge-tooltip
rshen91 Jan 5, 2022
9e61b47
fix: code review changes
rshen91 Jan 5, 2022
6d97cf6
fix: update chart api
rshen91 Jan 5, 2022
c0ad38d
fix: fix conditional
rshen91 Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ...stories-sagitta-offset-should-show-custom-value-formatter-in-tooltip-1-snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions packages/charts/src/chart_types/goal_chart/specs/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export interface BandFillColorAccessorInput {
export type BandFillColorAccessor = (input: BandFillColorAccessorInput) => Color;

/** @alpha */
export type GoalLabelAccessor = LabelAccessor<BandFillColorAccessorInput> | (() => string);
export type GoalLabelAccessor = LabelAccessor<BandFillColorAccessorInput>;

const defaultProps = {
chartType: ChartType.Goal,
Expand All @@ -54,7 +54,7 @@ export interface GoalSpec extends Spec {
tickValueFormatter: GoalLabelAccessor;
labelMajor: string | GoalLabelAccessor;
labelMinor: string | GoalLabelAccessor;
centralMajor: string | GoalLabelAccessor | (() => string);
centralMajor: string | GoalLabelAccessor;
centralMinor: string | GoalLabelAccessor;
angleStart: number;
angleEnd: number;
Expand Down
2 changes: 1 addition & 1 deletion packages/charts/src/components/__snapshots__/chart.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,4 +131,4 @@ exports[`Chart should render the legend name test 1`] = `
</div>
</Provider>
</Chart>"
`;
`;
2 changes: 1 addition & 1 deletion packages/charts/src/components/accessibility/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export function ScreenReaderTypes({
<dl>
<dt>Chart type:</dt>
<dd id={defaultSummaryId}>{chartTypeDescription}</dd>
{validGoalChart && goalChartData && typeof goalChartData.maximum === 'number' ? (
{validGoalChart && goalChartData && isNaN(goalChartData.maximum) ? (
nickofthyme marked this conversation as resolved.
Show resolved Hide resolved
<>
<dt>Minimum:</dt>
<dd>{goalChartData.minimum}</dd>
Expand Down
2 changes: 1 addition & 1 deletion storybook/stories/goal/2_gauge_with_target.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export const Example = () => {
centralMinor=""
angleStart={angleStart}
angleEnd={angleEnd}
tooltipValueFormatter={(d) => `${d}k USD`}
tooltipValueFormatter={(d) => `$${d}k USD`}
/>
</Chart>
);
Expand Down