-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(xy): expose isolated point style #2004
Conversation
bd5147f
to
80eaf68
Compare
buildkite update screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you were waiting on my review or not, but the changes look good to me.
Thanks, no I'm just waiting to test this in Kibana directly. I probably will consider exposing this configuration in the theme and tweaking this in Kibana rather than having this hardcoded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, tested locally and see no issues other than the one below. I left a few minor code comments in addition.
The point shapes story has a regression in the legend symbols.
Thank you @nickofthyme , this was actually a bug not previously discovered. It is fixed in 2199a2e |
buildkite update screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, changes LGTM! 🚢
This commit exposes the style of the isolated points in the theme (previously called orphan data points)
Summary
Fix part of #1902 by exposing the style of the isolated points.
Now the previously called
orphan
data points are renamed toisolated
points to follow a more mathematical semantic.Checklist
:xy
,:partition
):interactions
,:axis
):theme
label has been added and the@elastic/eui-design
team has been pinged when there areTheme
API changescloses #123
,fixes #123
)packages/charts/src/index.ts
dark
,light
,eui-dark
&eui-light