fix(bullet): full circle overlapping tick labels #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
buildkite update screenshots |
|
@markov00 could you take a look and this quick PR. As a first pass I am just adopting the approach from kibana to remove the max value of the 2 overlapping ticks. |
markov00
approved these changes
Mar 12, 2024
nickofthyme
pushed a commit
that referenced
this pull request
Mar 12, 2024
## [64.0.2](v64.0.1...v64.0.2) (2024-03-12) ### Bug Fixes * **bullet:** full circle overlapping tick labels ([#2350](#2350)) ([edbff68](edbff68)) * **deps:** update dependency @elastic/eui to ^93.3.0 ([#2356](#2356)) ([cf9ce81](cf9ce81)) * **deps:** update dependency @playwright/test to ^1.42.1 ([#2354](#2354)) ([03581bc](03581bc))
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simple fix for overlapping ticks on
CircleBullet chart. Also now allows passingticksasnumber[]instead of(domain: [number, number]) => number[].Details
This is a basic fix to remove the ending tick on the circular bullet whenever the start and end tick values are the same. This is to prevent overlapping.
This is not a perfect fix as it does not address the issue for when the label position are not equal but still overlap due to the length of the labels.
Checklist
:xy,:partition)closes #123,fixes #123)packages/charts/src/index.ts