docs: add randomness toggle on fit stacked series story #892
Conversation
stories/mixed/6_fitting_stacked.tsx
Outdated
| @@ -158,7 +159,7 @@ export const Example = () => { | |||
| const parsedEndValue: number | 'nearest' = Number.isNaN(Number(endValue)) ? 'nearest' : Number(endValue); | |||
| const value = number('Explicit value (using Fit.Explicit)', 5); | |||
| const xScaleType = dataKey === 'ordinal' ? ScaleType.Ordinal : ScaleType.Linear; | |||
| const rng = getRandomNumberGenerator(); | |||
| const rng = getRandomNumberGenerator(randomizeBoundingData ? undefined : '__seed__'); | |||
There was a problem hiding this comment.
This, running locally doesn't have an effect because, by default, the getRandomNumberGenerator picks up the RNG_SEED passed when running the storybook.
It has only an effect on the deployed version because we don't build Storybook with that SEED.
There was a problem hiding this comment.
Good point. I conditionally show the toggle if RNG_SEED is defined. I think it would be confusing for that boolean to have no effect in such case.
Codecov Report
@@ Coverage Diff @@
## master #892 +/- ##
=======================================
Coverage 69.58% 69.58%
=======================================
Files 321 321
Lines 10636 10636
Branches 2196 2196
=======================================
Hits 7401 7401
Misses 3226 3226
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 24.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Add randomness toggle on fit stacked series story per chat with @wylieconlon. Should be disabled by default to easily see the difference.
Checklist