-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improved domain error handling #933
feat: improved domain error handling #933
Conversation
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
==========================================
+ Coverage 70.11% 70.64% +0.53%
==========================================
Files 340 357 +17
Lines 10979 11324 +345
Branches 2382 2431 +49
==========================================
+ Hits 7698 8000 +302
- Misses 3267 3304 +37
- Partials 14 20 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
# [24.3.0](v24.2.0...v24.3.0) (2020-12-04) ### Bug Fixes * **highlighter:** show default highlighted radius with hidden dots ([#926](#926)) ([8b167a4](8b167a4)), closes [#679](#679) * **xy_chart:** improve line joins rendering ([#920](#920)) ([ec8041a](ec8041a)) * point highlight based on geom position and transform ([#934](#934)) ([7198b5d](7198b5d)) ### Features * allow no results component, don't require series ([#936](#936)) ([4766c23](4766c23)) * improved domain error handling ([#933](#933)) ([94534a5](94534a5))
🎉 This PR is included in version 24.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [24.3.0](elastic/elastic-charts@v24.2.0...v24.3.0) (2020-12-04) ### Bug Fixes * **highlighter:** show default highlighted radius with hidden dots ([opensearch-project#926](elastic/elastic-charts#926)) ([351c20c](elastic/elastic-charts@351c20c)), closes [opensearch-project#679](elastic/elastic-charts#679) * **xy_chart:** improve line joins rendering ([opensearch-project#920](elastic/elastic-charts#920)) ([9a6771c](elastic/elastic-charts@9a6771c)) * point highlight based on geom position and transform ([opensearch-project#934](elastic/elastic-charts#934)) ([196ee8d](elastic/elastic-charts@196ee8d)) ### Features * allow no results component, don't require series ([opensearch-project#936](elastic/elastic-charts#936)) ([6be5c8b](elastic/elastic-charts@6be5c8b)) * improved domain error handling ([opensearch-project#933](elastic/elastic-charts#933)) ([f480054](elastic/elastic-charts@f480054))
Summary
Fixes #932
Improves domain errors to fallback to logical defaults.
Use computed
minInterval
when customminInterval
is invalid.Use consistent rendering for custom domain. Currently, when min and max are provided that show no data, the charts is rendered. However, when setting a custom
min
domain that is greater than the computed max,no data
was rendered. Now the chart will display with the domain set to[min, min]
, such as...Similarly, when the custom
max
is less than the computed min,no data
was being rendered. Now the domain will default to[max, max]
, such as...Checklist