Fix test on Windows

elastic · Sep 13, 2023 · e478fd6 · e478fd6
1 parent 31e94c1
commit e478fd6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/internal/fields/dependency_manager.go b/internal/fields/dependency_manager.go
@@ -9,7 +9,6 @@ import (
 	"fmt"
 	"io"
 	"net/http"
-	"net/url"
 	"os"
 	"path/filepath"
 	"strings"
@@ -73,12 +72,8 @@ func loadECSFieldsSchema(dep buildmanifest.ECSDependency) ([]FieldDefinition, er
 
 func readECSFieldsSchemaFile(dep buildmanifest.ECSDependency) ([]byte, error) {
 	if strings.HasPrefix(dep.Reference, localFilePrefix) {
-		uri, err := url.Parse(dep.Reference)
-		if err != nil {
-			return nil, err
-		}
-
-		return os.ReadFile(uri.Path)
+		path := strings.TrimPrefix(dep.Reference, localFilePrefix)
+		return os.ReadFile(path)
 	}
 
 	gitReference, err := asGitReference(dep.Reference)

diff --git a/internal/fields/dependency_manager_test.go b/internal/fields/dependency_manager_test.go
@@ -6,7 +6,6 @@ package fields
 
 import (
 	"encoding/json"
-	"path/filepath"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -617,10 +616,9 @@ func TestDependencyManagerInjectExternalFields(t *testing.T) {
 
 func TestDependencyManagerWithECS(t *testing.T) {
 	const ecsNestedPath8_10_0 = "./testdata/ecs_nested_v8.10.0.yml"
-	ecsPath, _ := filepath.Abs(ecsNestedPath8_10_0)
 	deps := buildmanifest.Dependencies{
 		ECS: buildmanifest.ECSDependency{
-			Reference: "file://" + ecsPath,
+			Reference: "file://" + ecsNestedPath8_10_0,
 		},
 	}
 	dm, err := CreateFieldDependencyManager(deps)