Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes and refactors around profile and stack resources #1055

Closed
wants to merge 43 commits into from

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Dec 1, 2022

Refactors resources to decouple stack resources from profile metadata.

Some other changes:

@jsoriano jsoriano self-assigned this Dec 1, 2022
@jsoriano jsoriano marked this pull request as draft December 1, 2022 09:06
@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 1, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-09T18:46:34.968+0000

  • Duration: 33 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 890
Skipped 0
Total 890

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 1, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (35/35) 💚
Files 63.158% (84/133) 👎 -2.751
Classes 58.031% (112/193) 👎 -3.345
Methods 46.617% (379/813) 👎 -2.473
Lines 30.202% (3411/11294) 👎 -1.523
Conditionals 100.0% (0/0) 💚

@jsoriano
Copy link
Member Author

Closing this, bulk of the refactor was already merged in #1140 and cloud provider moved to #1230.

@jsoriano jsoriano closed this Apr 21, 2023
@jsoriano jsoriano deleted the profile-resources branch April 21, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce concept of current profile
2 participants