Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to select the stream under test in system test runner #187

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

andrewkroh
Copy link
Member

This provides a means to select a stream to test by input type.

Closes #186

This provides a means to select a stream to test by input type.

Closes elastic#186
@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 25, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #187 updated

  • Start Time: 2020-11-30T23:39:04.803+0000

  • Duration: 11 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

@andrewkroh andrewkroh marked this pull request as ready for review November 25, 2020 15:00
@ycombinator
Copy link
Contributor

Thanks for this change! Would you mind updating the HOWTO for system testing as well: https://github.com/elastic/elastic-package/blob/master/docs/howto/system_testing.md?

@andrewkroh
Copy link
Member Author

I added a section to describe the input option to the howto.

@@ -75,10 +75,11 @@ Next, we must define configuration for each data stream that we want to system t
config.yml
```

The `config.yml` file allows you define values for package and data stream-level variables. For example, the `apache/access` data stream's `config.yml` is shown below.
The `config.yml` file allows you to define values for package and data stream-level variables. For example, the `apache/access` data stream's `config.yml` is shown below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, again, for implementing this!

@andrewkroh andrewkroh merged commit 4a022f5 into elastic:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[System test runner] Allow input selection from config.yml
3 participants