Add full request and response to the log message context #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
@itsgoingd sorry for the late reply and thanks for the PR it looks very interesting. I'll have a look and merge asap, I didn't know the Clockwork project, looks awesome! |
|
Thanks, just signed the CLA. If this gets merged, I'd like to add a first-party support for Elasticsearch queries in Clockwork. :) |
|
Thanks @itsgoingd for this PR, I look forward to use Clockwork. Let me know if you need some help for more integrations. |
|
@itsgoingd I just released 8.6.0 that includes your PR, thanks again for your help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, this PR adds the request and response objects to the context of the log messages logged by the Transport class. This allows us to build more powerful log handlers with the ability to pull any info from the request and response objects instead of just using the predefined log message.
What is this good for? For example I've used this to build an integration with Clockwork that allows me to interactively inspect the request and response content.