-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async compatible classes #1480
Conversation
With pull request sethmlarson#1 we've removed the Can I take up this task?
What should this app do? Do we have a |
💚 CLA has been signed |
@clmno You certainly can, I'll create individual issues for tasks that don't need to be finished in this PR so you can work in tandem. Also, can you sign the CLA? Much appreciated! |
@seth-goodwin I've signed the CLA |
@sethmlarson How would I go about installing this locally and test it out?
When I run this, the Async classes do not seem to be loaded. |
Would love to know what @zikphil asked as well! |
@sethmlarson I tried using AsyncSearh with next code: from elasticsearch_dsl import AsyncSearch
search = AsyncSearch(using='my_connection_name', index='my_index_name')
search = search.filter('term', docType='my_docType_name')
result = search.count() and I get the following error: <...>
File "<..>/elasticsearch_dsl/_async/search.py", line 430, in count
return await es.count(index=self._index, body=d, **self._params)["count"]
TypeError: 'coroutine' object is not subscriptable I fix this the next code: count = await es.count(index=self._index, body=d, **self._params)
return count["count"] Proposal: fix this error similar code maybe later I prepare PR Edit: ready sethmlarson#2 |
Any chance this can be merged? |
Any update on this? |
When this AsyncSearch feature will be availble.. I don't see part of 7.4 release |
Sorry all, I've been focused on work in the client lately so this work has been put on hold. |
@sethmlarson thanks for the hard work. Do you think much has remained for this PR? Any on guess when it would be available? |
@sethmlarson |
Hi, I am very interested in this functionality. May I ask why we don't merge this feature, please? Any update, please? |
hey team, thank you so much for all the efforts. Could you please tell us more when do you expect to make it public? |
Closes #921
Closes #1355
TODOs:
Mapping
functions that use I/O, my first thought is to deprecate them in 7.x and remove in 8.xand instead use the
Mapping
class as only for storing metadata. These functions don't appear to be used anywherein the codebase so shouldn't have a big impact on users?
unasync
for unit tests as well? Either way need to test the new Async classesAsyncSearch
doesn't have anything to do with the/_async_search/*
endpoints_async/
,_base
, and_sync
directories_base
Create an example FastAPI application with(captured in issue Create an example FastAPI application with AsyncDocument and AsyncFacetedSearch #1482)AsyncDocument
andAsyncFacetedSearch