Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to specify script language in Document.update #1560

Closed
haynesgt opened this issue Jan 17, 2022 · 3 comments · Fixed by #1562
Closed

No way to specify script language in Document.update #1560

haynesgt opened this issue Jan 17, 2022 · 3 comments · Fixed by #1562

Comments

@haynesgt
Copy link
Contributor

elasticsearch_dsl==7.4.0

The script param is assumed to be a string here:

but there is no way to set the language of the script.

It would be more intuitive if it set body["script"] = script if the script param were a dict.

@sethmlarson
Copy link
Contributor

That'd be a nice addition, would you be able to open a PR with the feature and test(s)?

@haynesgt
Copy link
Contributor Author

ok

@haynesgt
Copy link
Contributor Author

haynesgt commented May 4, 2022

@sethmlarson could you review the pr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants