Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for script as a dict in update #1562

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

haynesgt
Copy link
Contributor

Closes #1560

@haynesgt haynesgt force-pushed the fix-update-script-lang branch from f15385d to 5fab077 Compare May 4, 2022 18:17
@miguelgrinberg miguelgrinberg force-pushed the fix-update-script-lang branch from 5fab077 to 50db902 Compare April 24, 2024 15:27
@miguelgrinberg
Copy link
Collaborator

Rebasing in preparation for merging, plus some minor changes to ensure compliance with the ES specification for scripted updates.

@miguelgrinberg miguelgrinberg merged commit f4f6f13 into elastic:main Apr 24, 2024
15 checks passed
@miguelgrinberg miguelgrinberg added the backport 8.x Backport to 8.x label Apr 29, 2024
Copy link

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-1562-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f4f6f138849d70de4099f54cccf376c2d4b2e540
# Push it to GitHub
git push --set-upstream origin backport-1562-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-1562-to-8.x.

miguelgrinberg pushed a commit to miguelgrinberg/elasticsearch-dsl-py that referenced this pull request Apr 29, 2024
miguelgrinberg added a commit that referenced this pull request Apr 29, 2024
(cherry picked from commit f4f6f13)

Co-authored-by: Gavin Haynes <haynesgt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 8.x Backport to 8.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to specify script language in Document.update
2 participants