Added Response.search_after() method #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelgrinberg
force-pushed
the
search-after
branch
from
88e81e3 to
0fb40d0
Compare
|
Nice work! it would be nice to have search_after shortcut built-in into this lib. |
pquentin
approved these changes
May 21, 2024
| @pytest.mark.asyncio | ||
| async def test_search_after_no_search(async_data_client): | ||
| s = AsyncSearch(index="flat-git") | ||
| with raises(ValueError): |
There was a problem hiding this comment.
nit: using the match parameter of pytest.raises would help clarify what errors we're actually raising here and in the following tests
There was a problem hiding this comment.
Sure, I'll add that as well. Thanks!
github-actions bot
pushed a commit
that referenced
this pull request
May 21, 2024
* Added Response.search_after() method * add match clause to pytest.raises (cherry picked from commit 891ba7c)
miguelgrinberg
added a commit
that referenced
this pull request
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to rebuild the change proposed in #1623 as independent pieces supporting
search_after, point-in-time, and ultimately a better version ofscan()that uses them.This PR implements
search_aftersupport in theResponseclass, also available through theSearchclass for convenience.